Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change color of box next to move in GameLog based on the player that made the move #4

Closed
nicolodavis opened this issue Nov 28, 2017 · 2 comments
Closed

Change color of box next to move in GameLog based on the player that made the move #4

nicolodavis opened this issue Nov 28, 2017 · 2 comments
Labels
feature good first issue

Comments

@nicolodavis
Copy link
Member

No description provided.

@coderwurst
Copy link

Hi @nicolodavis, I seen your post on r/boardgames and thought I could take a look. As I have not yet contributed to anything open source before, I would be interested in looking at this as a first task!

@nicolodavis
Copy link
Member Author

Please do. Looking forward to your contribution :)

@scheijan scheijan mentioned this issue Jan 2, 2018
Closed
scheijan added a commit to scheijan/boardgame.io that referenced this issue Jan 8, 2018
@scheijan
Change color of box next to move in GameLog based on the player that …
5a09876 
…made the move (boardgameio#4)
nicolodavis pushed a commit that referenced this issue Jan 11, 2018
@scheijan @nicolodavis
Change color of box next to move in GameLog (#70)
9ce42b2 
* Change color of box next to move in GameLog based on the player that made the move (#4)

* use Map instead of Set and split into multiple lines for readability

* disable broadcasting the RESTORE action because it confuses log rewinding

* fix test
sedobrengocce pushed a commit to sedobrengocce/boardgame.io that referenced this issue Mar 21, 2018
@scheijan @nicolodavis
Change color of box next to move in GameLog (boardgameio#70)
979c98d 
* Change color of box next to move in GameLog based on the player that made the move (boardgameio#4)

* use Map instead of Set and split into multiple lines for readability

* disable broadcasting the RESTORE action because it confuses log rewinding

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolodavis @coderwurst