Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ctrl-c play nicely with capybara #59

Closed
ianks opened this issue Feb 18, 2019 · 4 comments
Closed

Make ctrl-c play nicely with capybara #59

ianks opened this issue Feb 18, 2019 · 4 comments

Comments

@ianks
Copy link
Contributor

ianks commented Feb 18, 2019

currently when using iodine capybara-rspec, ctrl-c does not seem to be propogated properly back to rspec, so the specs will continue to run. if you press ctrl-c again, the tests will immediately stop and not inform the user which tests failed.

it would be great if iodine had the same behavior as puma here, where ctrl-c would be delegated to rspec so it would inform the user which specs failed.

boazsegev added a commit that referenced this issue Feb 18, 2019
@boazsegev
Copy link
Owner

Hi @ianks ,

Thank you for opening this issue.

I authored a patch on the git master branch that would allow signals to propagate to pre-exiasting handlers (I assume this will lead to the Ruby signal handling code).

I didn't release the patch yet, since I don't have time to properly test it tonight. Feel free to try it out and let me know by installing iodine from the git master branch.

In a Gemfile this can be done by including iodine like so:

gem 'iodine', git: 'https://github.com/boazsegev/iodine'

I think it's also possible to use the gem specific_install command in the terminal:

gem specific_install -l https://github.com/boazsegev/iodine.git

Good luck! I hope this solves your issue. Please keep me posted.

Kindly,
Bo.

@ianks
Copy link
Contributor Author

ianks commented Feb 23, 2019

Works swimmingly! Thank you!

@vitobotta
Copy link

HI! I am testing iodine now and I'm having this issue with the latest version. What can I do? Thanks!

@boazsegev
Copy link
Owner

@vitobotta ,

This issue was fixed by forwarding the SIGINT and SIGTERM signal(s) to any active Ruby trap. Could you open a new issue describing what isn't working and how iodine is failing?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants