Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track down unwanted text-transform: uppercase in the block editor #77

Closed
bobbingwide opened this issue Sep 19, 2022 · 6 comments
Closed
Assignees
Labels
bug Something isn't working Gutenberg Related to Gutenberg - the WordPress block editor help wanted Extra attention is needed

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Sep 19, 2022

In jetpack.wp.a2z I've noticed that there are a number of instances of inline CSS with text-transform: uppercase.
This is making it difficult to use the block editor, especially when the text being transformed is an input field and the content was originally created in mixed case.

image
In this example we see the text of the Jetpack Consent field being uppercased.
The inline style for the control's label is being applied to the Jetpack field label's contents.

.css-1v57ksj {
    font-size: 11px;
    font-weight: 500;
    line-height: 1.4;
    text-transform: uppercase;
    display: inline-block;
    margin-bottom: calc(8px);
    padding: 0px;
}

Deselecting the text-transform: uppercase in the inspector we see the text in the case it was originally written.
Here you can see that I'd edited it and typed an uppercase N to match what I could see.

Can we seNd you an email from time to time?

Also the labels in the Settings panels are being uppercased: eg Size, Default and Radius

With Gutenberg:
image

Without Gutenberg:
image

It's probably the same issue.

@bobbingwide bobbingwide added bug Something isn't working help wanted Extra attention is needed Gutenberg Related to Gutenberg - the WordPress block editor labels Sep 19, 2022
@bobbingwide bobbingwide self-assigned this Sep 19, 2022
@bobbingwide bobbingwide changed the title Track down unwanted text-transform: uppercase in the block editor Track down unwanted text-transform: uppercase in the block editor Sep 19, 2022
@bobbingwide
Copy link
Owner Author

@bobbingwide
Copy link
Owner Author

Note that the text-transform: uppercase applies in the block editor. On the front end it's OK... apart from the accidental editing of the content with UPPERCASE characters.
See https://jetpack.wp-a2z.org/block/consent-jetpack-field-consent/

@bobbingwide
Copy link
Owner Author

bobbingwide commented Sep 26, 2022

The uppercasing affects other blocks. Here's a screenshot of a Checkbox in CoBlock's Request a Quote variation of the Form block.
image

Note: CoBlock's code appears to violate the guidelines in the Accessibility concerns section of https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label

@muhme
Copy link

muhme commented Jan 11, 2024

I have the same unwanted UPERCASE on my block control labels. And also the block editor tutorial shows the problem with "STARTING YEAR" in the editor for label property “Starting year”.

@bobbingwide
Copy link
Owner Author

#77 (comment)

I don't think we'll be able to do anything about this with regards to the block editor. I found out what was happening. So now we just have to live with it.

@muhme
Copy link

muhme commented Jan 12, 2024

Yes, the labelling of the controls should be in capital letters, see WordPress/gutenberg#42782, so I'll leave it at that - thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Gutenberg Related to Gutenberg - the WordPress block editor help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants