Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eBPS meetings shortcode should be styled the same as the Events Calendar widget #2

Open
4 of 5 tasks
bobbingwide opened this issue Nov 25, 2021 · 3 comments
Open
4 of 5 tasks
Assignees
Labels
enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Nov 25, 2021

One of the tasks in #1 is to ensure that the output of the [ebps-meetings] shortcode is

Styled the same as the Events Calendar widget

In this first version the generated HTML almost exactly reflects the HTML produced by the Events List widget.
When The Events Calendar is deactivated its CSS isn't enqueued.
We need to copy some of the CSS used the style the output and enqueue it ourselves.

Proposed solution

  • Enqueue CSS in a file called css/ebps-meetings.css
  • Code enough CSS to make it look the same.
  • Take into account that there's also some CSS in the twentyfourteen-child theme.
  • Investigate performance benefits of enqueing the CSS inline
  • Only enqueue CSS when the tribe_events post type needs to be registered.
@bobbingwide bobbingwide added the enhancement New feature or request label Nov 25, 2021
@bobbingwide bobbingwide self-assigned this Nov 25, 2021
@bobbingwide
Copy link
Owner Author

bobbingwide commented Nov 25, 2021

Investigate performance benefits of enqueing the CSS inline

  • Obtain figures before inlining the CSS
  • Obtain figures after inlining the CSS

@bobbingwide
Copy link
Owner Author

When the Events calendar plugin is activated and we want to use the [ebps-meetings] shortcode instead of the widget then then CSS is not being delivered so we lose a lot of the styling.
Also, Andrew wants the View calendar link to be green initially.

@bobbingwide
Copy link
Owner Author

The CSS for the View Calendar should also cater for the Block widget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant