Cater for duplicate field names with different keys

[bobbingwide]

While trying to develop PHPUnit tests for each field type I encountered a problem where the field name Text was being displayed for the wrong post type.

Explanation

• The field's key was different from the expected value.
• This was due to the fact that in a field group called Layout I'd used the clone field type with a clone of the Basic group.
• I'd changed the Basic group to apply to the test-acf-fields CPT, but I'd not yet changed the Layout group.
• The Text field being displayed was from the cloned group. Its key was field_64abd97b8ff80_field_64aa869f48df7

Proposed solution

TBC

[bobbingwide]

In s.b/oikcom I must have created the ACF field blocks for the fields in the Basic group before I created the Layout group.
However I note that the attributes don't show the expected value for the field key ( _acf_field_name ).

<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field",
"data":{"acf-field-name":"text","_acf-field-name":"field_645f589a88304"},
"mode":"edit","backgroundColor":"very-light-gray","fontSize":"normal"} /-->

[bobbingwide]

However I note that the attributes don't show the expected value for the field key ( _acf_field_name ).

What we see in the data attribute are two values for acf-field-name and _acf-field-name
The value for acf-field-name is the user friendly field name.
The value for _acf-field-name is the ACF internal name for the acf-field-name attribute.
It's NOT the ACF internal name for the text field.

I believe I need to change the code such that the field name is actually the field's key.

[bobbingwide]

Having done this the HTML for the block is simplified
For the original text field it becomes

<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field",
"data":{"field_645f589a88304":"field_64aa869f48df7"},
"mode":"preview"} /-->

For the cloned field in the Layout group it becomes.

<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field",
"data":{"field_645f589a88304":"field_64abd97b8ff80_field_64aa869f48df7"},
"mode":"edit"} /-->

[bobbingwide]

It would appear that the simplified version is only temporary; it's what's displayed in the Code Editor when in edit mode.

When saved the data attribute is more complicated.

<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field",
"data":{"acf-field-name":"field_64aa869f48df7","_acf-field-name":"field_645f589a88304"},
"mode":"edit"} /-->

[bobbingwide]

The value for the acf-field-name attribute in data is now the field's key. This is currently used to generate the classNames for the div.

<div class="acf-field-field_64aa869f48df7 acf-type-text has-text-align- wp-block-acf-field-acf-field">rendered text field</div>

It would be nice to be able to map the key back to the name given by the user.
This would improve the message shown when the field is not set.

<p>Field field_64aa869f48df7 not set for post ID 0</p>

Rather than field_64aa869f48df7 we'd see text.