Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ad hoc tracing of filter results #6

Closed
bobbingwide opened this issue Sep 14, 2015 · 1 comment
Closed

Add ad hoc tracing of filter results #6

bobbingwide opened this issue Sep 14, 2015 · 1 comment
Assignees
@bobbingwide
Labels
enhancement
Milestone
2.0.6

Comments

@bobbingwide
Copy link
Owner

It would be nice to see the results of selected filters in the trace log.

Proposed solution

Add a Filter results to trace text area field to the action options admin page in which the names of the filters to trace are specified, comma separated.

For each filter listed attach bw_trace_results() to trace the returned value. This will trace the returned value and optionally, when tracing at BW_TRACE_DEBUG will also trace the other parameters passed.

Notes:

Some filters such as gettext and gettext_with_context are invoked many hundreds of times per transaction. You could get a lot of output.
@bobbingwide bobbingwide self-assigned this Sep 14, 2015
@bobbingwide bobbingwide added this to the 2.0.6 milestone Sep 14, 2015
This was referenced Sep 14, 2015
Open
Closed
bobbingwide added a commit that referenced this issue Sep 14, 2015
@bobbingwide
Fix Issue #6
23e5e1b
bobbingwide added a commit that referenced this issue Sep 14, 2015
@bobbingwide
v2.0.6 - Another attempt to commit the README and language files
eba14e0 
and also to automatically close the GitHub Issues

* Added: Ad-hoc tracing of filter functions for selected hooks ( Issue #3 )
* Added: Ad-hoc tracing of parameters to selected hooks ( Issue #2 )
* Added: Ad-hoc tracing of the global post object on selected hooks ( Issue #2 )
* Added: Ad-hoc tracing of filter results ( Issue #6 )
* Added: Ad-hoc tracing should allow selection of the hook priority ( Issue #10 )
* Added: BW_TRACE_VERBOSE ( 64 ) level, which is even more detailed than BW_TRACE_DEBUG ( 32 )
* Changed: Enhanced output from Count action hooks and filters ( Issue #7 )
* Changed: Functions traced should allow OO methods invoking trace ( Issue #8 )
* Fixed: Ensure BW_TRACE_level constants are defined ( Issue #4 )
* Fixed: Fix for problem with symlinked file's drive letters ( similar to TRAC #33265 )
* Fixed: Only trace $errcontext when tracing with BW_TRACE_VERBOSE ( Issue #5 )
* Fixed: Strings containing commas in the trace summary file should be wrapped in quotes ( Issue #9 )
@bobbingwide bobbingwide changed the title Add ad-hoc tracing of filter results Add ad hoc tracing of filter results Oct 1, 2015
@bobbingwide
Copy link
Owner Author

This was fixed in 2.0.6 but I used the wrong string form for the commit to close the issue.
Fix Issue #6 rather than Fixes #6 or other variations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobbingwide bobbingwide

Labels
enhancement
Projects
None yet
Milestone
2.0.6
Development

No branches or pull requests
1 participant
@bobbingwide