Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cater for deleted logic: files, classes, functions and methods #34

Open
bobbingwide opened this issue Jul 5, 2016 · 2 comments
Open

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Jul 5, 2016

Some plugins remove logic between versions.
Some plugins deprecate functions, others simply remove them.
oik-shortcodes needs to cater for deletions of

  • files
  • classes
  • functions
  • methods

and possibly

  • hooks
  • shortcodes

Example.
The class Jetpack_VideoPress_Shortcode was in jetpack/modules/videopress/shortcode.php in v3.9.6.

The class no longer exists in the latest version ( 4.0.4 ); it was removed by changes in Automattic/jetpack@ba4af49

@bobbingwide
Copy link
Owner Author

Note: The parser for the official WordPress Reference caters for deletions. Perhaps it's time to spend more time on this solution.

@bobbingwide
Copy link
Owner Author

bobbingwide commented Oct 31, 2016

In my first attempt at logic that will completely delete the API reference before rebuilding, I left a few oik_parsed_source records in the database.

These should be tidied by modifying set_md5_hash.php to delete any oik_parsed_source record that refers to a post, via oik_sourceref, that is no longer present.

This is not particularly important since it was only for one plugin in a test system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant