Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Howdy,' replacement string replacement no longer working in WordPress 4.7, again in 4.8 #63

Closed
bobbingwide opened this issue Jan 17, 2017 · 1 comment
Assignees
Labels

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Jan 17, 2017

In WordPress 4.7 a change was made to the logic that translates the 'Howdy,' string.
From $howdy = sprintf( __('Howdy, %1$s'), $current_user->display_name );
To $howdy = sprintf( __( 'Howdy, %s' ), $current_user->display_name );

See https://core.trac.wordpress.org/ticket/37794

oik is still using the original string to re-run the translation, but it no longer gets translated due to the parameter format change, so oik's string replacement logic no longer works.

Proposed solution

  • The code in oik needs to reflect the change to core.
  • It's not necessary to make the code backward compatible with earlier versions of WordPress.
@bobbingwide bobbingwide self-assigned this Jan 17, 2017
@bobbingwide
Copy link
Owner Author

bobbingwide commented Aug 22, 2017

Now it doesn't work in 4.8 - see https://core.trac.wordpress.org/attachment/ticket/40342/40342.2.diff - part of WordPress TRAC 40342.
The current user display name is now within a span class="display-name" tag.

@bobbingwide bobbingwide reopened this Aug 22, 2017
@bobbingwide bobbingwide changed the title 'Howdy,' replacement string replacement no longer working in WordPress 4.7 'Howdy,' replacement string replacement no longer working in WordPress 4.7, again in 4.8 Aug 22, 2017
bobbingwide added a commit that referenced this issue Aug 22, 2017
bobbingwide added a commit that referenced this issue Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant