Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Gutenberg 11.2.0; Fatal error due attempting to display query-loop #16

Closed
bobbingwide opened this issue Aug 5, 2021 · 2 comments
Labels
enhancement New feature or request Gutenberg A bug / enhancement to Gutenberg

Comments

@bobbingwide
Copy link
Owner

It happened with Fizzie and again with SB.
The logic run when Gutenberg finds a query-loop block is flawed and leads to a Fatal error for each query-loop block.

See bobbingwide/fizzie#70 (comment)

We need to update SB for Gutenberg 11.2.0.

The query-loop override implemented for the home page needs to be applied to work against the post-template block.

@bobbingwide bobbingwide added enhancement New feature or request Gutenberg A bug / enhancement to Gutenberg labels Aug 5, 2021
@bobbingwide
Copy link
Owner Author

bobbingwide commented Aug 5, 2021

Having resolved the first part of the problem it now appears that the override logic attempt to respect the flex layout request specified on the query block works.

<!-- wp:query {"queryId":3,"query":{"perPage":8,"pages":0,"offset":0,"postType":"bigram","categoryIds":[],"tagIds":[],"order":"desc","orderBy":"date","author":"","search":"","exclude":[],"sticky":"","inherit":true},"layout":{"type":"flex","columns":4}} -->

The attribute is now called displayLayout.
layout is for the Layout settings toggle: Inherit default layout

@bobbingwide
Copy link
Owner Author

SB v0.2.1 now delivered supporting Gutenberg 13.1.0. Closing therefore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Gutenberg A bug / enhancement to Gutenberg
Projects
None yet
Development

No branches or pull requests

1 participant