Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust CSS for vertical navigation menu in sidebar and footer widgets #9

Closed
bobbingwide opened this issue Mar 25, 2021 · 3 comments
Closed
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Mar 25, 2021

The CSS that styles the main menu is also being applied to the menus in the sidebar and footer.
There are a couple of problems with this
image

  1. It doesn't match what we see on the live site
  2. In the sidebar the longer menu items get scrunched up.
@bobbingwide bobbingwide self-assigned this Mar 25, 2021
@bobbingwide bobbingwide added the bug Something isn't working label Mar 25, 2021
bobbingwide added a commit that referenced this issue Mar 26, 2021
@bobbingwide
Copy link
Owner Author

The menu styling change made in March relied on the navigation menu template part being given a tagName attribute of nav.

<!-- wp:template-part {"slug":"main-menu","theme":"sb","align":"wide","layout":{"contentSize":"80%","wideSize":"90%"},"tagName":"nav"} /-->

This tagName option is not available in the Site Editor. Is this an oversight?

@bobbingwide
Copy link
Owner Author

In the sidebar the longer menu items get scrunched up.

The longer menu items still get scrunched up in the main menu, especially when the mobile menu is being displayed. See #33

@bobbingwide bobbingwide added the enhancement New feature or request label May 12, 2022
@bobbingwide
Copy link
Owner Author

The longer menu items still get scrunched up in the main menu, especially when the mobile menu is being displayed

Fixed by changes for #33 in v0.3.1. Closing therefore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant