New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alarm motion event database #46
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise you will have the django.core.exceptions.ImproperlyConfigured exception because tasks import models and to do so the app is using INSTALLED_APPS django settings, and thus it's not initialized yet. So we're doing it before imports.
Otherwise the main thread is locked by the DetectMotion thing. So, the mqtt_client doesn't send every x seconds the PINGREQ. Fix issue #45
mxmaxime
commented
Aug 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device_id
field (Add "device_id" to MQTT motion detect messages #21) we can use it for mqtt client id, because they have to be unique. In the future we could have multiple instance of these piece of software, so we usedevice_id
inclient_id
to ensure it to be unique 👍self.mqtt_client.loop_start()
and we start/initialize mqtt client instart
method and not in the class constructor, otherwise it's not working silently, no errors but doesn't work. This method is called in a Thread, because this class is executed by a Thread when the alarm is up.Remaining questions
What to save in database
Please see issue #70