Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] possibility to implement custom line number formatting #518

Merged
merged 4 commits into from
Aug 12, 2023

Conversation

Mino260806
Copy link
Contributor

Suggested here #517

Now configurable via Gutter.setLineNumberFormatter, by implementing LineNumberFormatter interface
Also added an example in demo

Demo

Added under View > Line Number Format > Hindu-Arabic (default selected option is Normal)
demo

@bobbylight bobbylight self-requested a review August 8, 2023 23:47
@codecov-commenter
Copy link

Codecov Report

Merging #518 (119799d) into master (4a08790) will decrease coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 65.38%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff              @@
##             master     #518      +/-   ##
============================================
- Coverage     73.37%   73.37%   -0.01%     
- Complexity     6598     6604       +6     
============================================
  Files           175      175              
  Lines         29867    29888      +21     
  Branches       3882     3883       +1     
============================================
+ Hits          21916    21930      +14     
- Misses         6120     6127       +7     
  Partials       1831     1831              
Files Changed Coverage Δ
...ea/src/main/java/org/fife/ui/rtextarea/Gutter.java 82.33% <50.00%> (-0.95%) ⬇️
...ain/java/org/fife/ui/rtextarea/LineNumberList.java 62.54% <72.22%> (+0.30%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Owner

@bobbylight bobbylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@bobbylight bobbylight merged commit 4f24ac1 into bobbylight:master Aug 12, 2023
5 of 7 checks passed
@bobbylight bobbylight added this to the 3.3.5 milestone Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants