Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codeql #84

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix codeql #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cdd772c
use same version of golang in codeql as test harness
bobcallaway Feb 25, 2022
0b7b635
stop using autobuilder
bobcallaway Feb 25, 2022
cd10661
debug and use makefile consistently
bobcallaway Feb 25, 2022
37a9010
try2
bobcallaway Feb 25, 2022
9ff1084
trying this
bobcallaway Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ on:
permissions:
security-events: write

env:
GO_VERSION: 1.16.8

jobs:
analyze:
name: Analyze
Expand All @@ -37,14 +40,27 @@ jobs:
- name: Checkout repository
uses: actions/checkout@ec3a7ce113134d7a93b817d10a8272cb61118579 # v2.4.0

- name: Set up Go
uses: actions/setup-go@bfdd3570ce990073878bf10f6b2d79082de49492 #v2.2.0
with:
go-version: ${{ env.GO_VERSION }}

- name: Leverage Cached Go Modules
uses: actions/cache@937d24475381cd9c75ae6db12cb4e79714b926ed #v2.1.7
with:
path: ~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@75f07e7ab2ee63cba88752d8c696324e4df67466 # v1.1.3
with:
languages: ${{ matrix.language }}

- name: Autobuild
uses: github/codeql-action/autobuild@75f07e7ab2ee63cba88752d8c696324e4df67466 # v1.1.3
queries: +security-and-quality

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@75f07e7ab2ee63cba88752d8c696324e4df67466 # v1.1.3
env:
CODEQL_EXTRACTOR_GO_BUILD_COMMAND: "make pkg"
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ jobs:
${{ runner.os }}-go-

- name: Build
run: go build -v ./...
run: make pkg

- name: Test
run: go test -v ./...
run: make test

- name: Ensure no files were modified as a result of the build
run: git update-index --refresh && git diff-index --quiet HEAD -- || git diff --exit-code
4 changes: 2 additions & 2 deletions pkg/signature/kms/hashivault/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ func init() {
type hashivaultClient struct {
client *vault.Client
keyPath string
transitSecretEnginePath string
transitSecretEnginePath string // lgtm[go/hardcoded-credentials]
keyCache *ttlcache.Cache
keyVersion uint64
}
Expand Down Expand Up @@ -129,7 +129,7 @@ func newHashivaultClient(address, token, transitSecretEnginePath, keyResourceID
transitSecretEnginePath = os.Getenv("TRANSIT_SECRET_ENGINE_PATH")
}
if transitSecretEnginePath == "" {
transitSecretEnginePath = "transit"
transitSecretEnginePath = "transit" // lgtm[go/hardcoded-credentials]
}

hvClient := &hashivaultClient{
Expand Down