Build using setuptools natively #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurie O <laurie_opperman@hotmail.com>
Merged
|
First, I want to thank you for contributing! This is what I need! As you can see this is my first open-source project and this is exactly where I needed help as I am not an expert on Python packaging etc. Second, for this commit, can we include a change to delete the local pybind11 subrepo then since it seems that it will be no longer needed. Thanks! |
|
Will do. I've enabled maintainer edits, so you're able to make changes and push them to my branch However, removing PyBind11 will break the cmake test build. I think this is fine as we only need to test the Python code, which is done via PyTest anyway |
|
Thanks a lot! @EpicWink |
It's used in the build requirements during install Signed-off-by: Laurie O <laurie_opperman@hotmail.com>
This reverts commit cdfc7ed.
|
Hi sorry, given we have #4 coming let's just keep the pybind11 submodule for now and I will merge this. |
chaitan94
added a commit
to chaitan94/pytomlpp
that referenced
this pull request
Jun 20, 2020
bobfang1992
pushed a commit
that referenced
this pull request
Jun 20, 2020
chaitan94
added a commit
to chaitan94/pytomlpp
that referenced
this pull request
Jun 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now simply install with
pip install ..This will allow for simple wheel building with
python setup.py bdist_wheelorpip wheel . --no-deps. This is required for PyPI distribution.Note that the bundled (Git module) PyBind11 isn't used: rather,
pipgets is during the build process. This means people with only the source-distribution (created bypython setup.py sdist) can install it without any pre-requisites.