Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional encoding parameter to load and dump functions #81

Merged
merged 12 commits into from
Jan 3, 2024

Conversation

Backist
Copy link
Contributor

@Backist Backist commented Jan 2, 2024

An optional encoding parameter has been added to the dump and load functions to provide more flexibility in specifying encoding, rather than always using the system default.

@Backist
Copy link
Contributor Author

Backist commented Jan 2, 2024

After several hours of struggling with my machine with a GIT Bash problem, I present the final PR including the encoding parameter to the dump and load functions. Although I had initially set utf-8 as the default for enconding, it seemed that some tests were using different encodings, so I considered leaving it at None and letting the user set the required encoding.

@Backist
Copy link
Contributor Author

Backist commented Jan 2, 2024

PS: Apologies for the number of failed or cancelled PRs. Several of them were not correct or had late commits due to the problem with my GIT Bash that I mentioned.

@Backist
Copy link
Contributor Author

Backist commented Jan 2, 2024

@bobfang1992 Awaiting review. Everything should now be in order.

@bobfang1992
Copy link
Owner

Thanks, will merge if all CI passes

@bobfang1992 bobfang1992 merged commit 8c7b4c3 into bobfang1992:master Jan 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants