Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade(dependencies): Upgraded dependencies to latest version #9

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

ThomasK33
Copy link
Contributor

Hey, I ran into some nasty nil-pointer issues when running the project.
After upgrading the golang.org/x/tools version, they were fixed/gone.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7930790615

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.146%

Totals Coverage Status
Change from base Build 7682394639: 0.0%
Covered Lines: 649
Relevant Lines: 820

💛 - Coveralls

Copy link
Owner

@bobg bobg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

You've also helped me discover that Modver (one of my CI steps) doesn't work when forks are involved - thanks for that too. (Bug filed.)

@bobg bobg merged commit 77d5457 into bobg:main Feb 16, 2024
1 check failed
@bobg
Copy link
Owner

bobg commented Feb 18, 2024

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires (at least) an increase in your module's minor version number.

minimum Go version changed from 1.21 to 1.22
  Minor

@bobg
Copy link
Owner

bobg commented Feb 18, 2024

Thanks once again @ThomasK33 - that Modver bug you helped me find is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants