Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoclean #33

Merged
merged 2 commits into from
May 13, 2023
Merged

Autoclean #33

merged 2 commits into from
May 13, 2023

Conversation

bobg
Copy link
Owner

@bobg bobg commented May 13, 2023

This PR adds the "autoclean" feature: output files of Files targets can be added to a registry for use by Clean.

It incidentally changes Clean from a function to a type. It also configures a few new linters and fixes some things they found.

@github-actions
Copy link

github-actions bot commented May 13, 2023

Pull Request Test Coverage Report for Build 4967234382

  • 74 of 85 (87.06%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 73.615%

Changes Missing Coverage Covered Lines Changed/Added Lines %
command.go 3 5 60.0%
clean.go 36 45 80.0%
Files with Coverage Reduction New Missed Lines %
command.go 1 77.05%
Totals Coverage Status
Change from base Build 4964966395: 0.3%
Covered Lines: 1621
Relevant Lines: 2202

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented May 13, 2023

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires an increase in your module’s major version number.
If the new major version number is 2 or greater,
you must also add or update the version suffix
on the module path defined in your go.mod file.
See the Go Modules Reference for more info.

checking Clean
  func(files ...string) github.com/bobg/fab.Target went from function to non-function
    Major

@bobg bobg marked this pull request as ready for review May 13, 2023 13:53
@bobg bobg merged commit 234bc71 into main May 13, 2023
2 checks passed
@bobg bobg deleted the bobg/autoclean2 branch May 13, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant