Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file support and misc changes #35

Merged
merged 7 commits into from
May 24, 2023
Merged

Improve file support and misc changes #35

merged 7 commits into from
May 24, 2023

Conversation

bobg
Copy link
Owner

@bobg bobg commented May 24, 2023

Add Glob. Add better support for directories in Files. Make YAMLStringList and YAMLStringListFromNodes into methods on Controller and make them take a dir argument. Sprinkle in some missing calls to con.JoinPath.

@github-actions
Copy link

Pull Request Test Coverage Report for Build 5069567017

  • 47 of 58 (81.03%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 74.15%

Changes Missing Coverage Covered Lines Changed/Added Lines %
yaml.go 6 7 85.71%
proto/proto.go 0 2 0.0%
files.go 34 42 80.95%
Totals Coverage Status
Change from base Build 4973553730: 0.2%
Covered Lines: 1701
Relevant Lines: 2294

💛 - Coveralls

@github-actions
Copy link

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR requires an increase in your module’s major version number.
If the new major version number is 2 or greater,
you must also add or update the version suffix
on the module path defined in your go.mod file.
See the Go Modules Reference for more info.

checking RegisterYAMLStringList
  in parameters of func(name string, fn func(*gopkg.in/yaml.v3.Node) ([]string, error))
    in parameters of func(*gopkg.in/yaml.v3.Node) ([]string, error)
      1 param(s) to 3
        Major

@bobg bobg merged commit e7d84ac into main May 24, 2023
2 checks passed
@bobg bobg deleted the bobg/files-dir branch May 24, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant