Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Document Dijkstra Shortest Path #59

Closed
bobluppes opened this issue Aug 6, 2023 · 2 comments
Closed

[DOCS] Document Dijkstra Shortest Path #59

bobluppes opened this issue Aug 6, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@bobluppes
Copy link
Owner

Documentation Dijkstra Shortest Path

The goal of this issue if the improve the documentation of an existing algorithm. This documentation should go into the algorithms section of our docusaurus docs.

More detail on how to build the documentation locally can be found on the wiki.

An existing documentation page exists, which should be extended. The page can be found under docs/docs/algorithms/shortest-path/dijkstra.md.

The corresponding algorithm is called dijkstra_shortest_path and can be found under include/graaflib/algorithm/shortest_path.h.

Documentation Contents

The documentation entry should adhere to the following template:

# [ALGORITHM_NAME]
- A short description of the algorithm, what does it do and in which use cases is it used.
- What are the limitations of the algorithm, does it work on both directed and undirected graphs? Does it consider edge weights, and if yes, does it support negative weights?
- Link to the wikipedia entry on the algorithm.

## Syntax
- A code block with the syntax of the algorithm. This should now include any javadoc comments.
- An explanation of the parameters (including template parameters) and the return type.

## (Optional) See also
- If there are similar algorithms, or we have a slightly different version of the same algorithm, you can link it here.
- If we have an example (found on the example page of the docs) which uses this algorithm, you can link it here.
@bobluppes bobluppes added documentation Improvements or additions to documentation help wanted Extra attention is needed good first issue Good for newcomers labels Aug 6, 2023
@bobluppes bobluppes pinned this issue Aug 6, 2023
@bobluppes bobluppes added this to the release 1.0.0 milestone Aug 9, 2023
@MichaeINeumann
Copy link
Contributor

Hi, I would like to help but I have seen there is already a "docs: add documentation for dijkstra (#66)" added. Does this make this task obsolete, or is it to further improve dijkstra.md? I tried to install yarl, unfortunately without success. Is this mandatory or is it just to edit/enhance the markdown file.

@bobluppes
Copy link
Owner Author

Hi @MichaeINeumann, thanks for your interest! You are correct, in the other PR we added a documentation entry for both versions of the Dijkstra algorithm. I did however forget to close this ticket 😬

If you are interested in picking up a documentation ticket, maybe one of the following could be of interest:

I would highly recommend installing yarn when working on the documentation, as it allows you to serve the documentation locally. This makes it very easy to observe the effect of your changes. If you have npm installed on your system you can install yarn using:

npm install --global yarn

On another note, I see that all algorithm tickets are assigned. I plan on adding more this afternoon in case you are interested.

@bobluppes bobluppes unpinned this issue Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants