Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking-change: Expose algorith names to interface #50

Merged
merged 3 commits into from
Aug 5, 2023

Conversation

bobluppes
Copy link
Owner

Should be merged after #48

This PR exposes the algorithm names to the user. For example, instead of calling get_shortest_path, the user now calls dijkstra_shortest_path. This should also make it easier to add new algorithms.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 99.23% and project coverage change: -0.01% ⚠️

Comparison is base (7bd1094) 99.80% compared to head (a838c59) 99.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
- Coverage   99.80%   99.80%   -0.01%     
==========================================
  Files          22       22              
  Lines        1011     1009       -2     
==========================================
- Hits         1009     1007       -2     
  Misses          2        2              
Files Changed Coverage Δ
include/graaflib/algorithm/cycle_detection.tpp 95.12% <94.73%> (-0.23%) ⬇️
include/graaflib/algorithm/graph_traversal.tpp 100.00% <100.00%> (ø)
include/graaflib/algorithm/shortest_path.h 100.00% <100.00%> (ø)
include/graaflib/algorithm/shortest_path.tpp 100.00% <100.00%> (ø)
include/graaflib/properties/vertex_properties.tpp 100.00% <100.00%> (ø)
test/graaflib/algorithm/cycle_detection_test.cpp 100.00% <100.00%> (ø)
test/graaflib/algorithm/graph_traversal_test.cpp 100.00% <100.00%> (ø)
test/graaflib/algorithm/shortest_path_test.cpp 100.00% <100.00%> (ø)
...est/graaflib/properties/vertex_properties_test.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobluppes bobluppes merged commit aebb1b3 into main Aug 5, 2023
7 of 8 checks passed
@bobluppes bobluppes deleted the expose-algorith-names branch August 5, 2023 21:19
@bobluppes bobluppes added breaking-change A change which changes the public API refactor A change which does not change any behavior labels Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A change which changes the public API refactor A change which does not change any behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant