Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking-change: Re-use graph traversal in bfs_shortest_path #65

Merged
merged 9 commits into from
Aug 9, 2023

Conversation

bobluppes
Copy link
Owner

@bobluppes bobluppes commented Aug 8, 2023

This PR does the following:

  • Adds an optional search_termination_strategy to BFS and DFS
  • Refactors bfs_shortest_path to make use of the existing breadth_first_traverse
  • Fixes the expected path length in shortest path tests

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 99.20% and project coverage change: -0.08% ⚠️

Comparison is base (b4f9e10) 99.81% compared to head (275f359) 99.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   99.81%   99.73%   -0.08%     
==========================================
  Files          22       23       +1     
  Lines        1076     1140      +64     
==========================================
+ Hits         1074     1137      +63     
- Misses          2        3       +1     
Files Changed Coverage Δ
include/graaflib/algorithm/graph_traversal.tpp 96.55% <94.11%> (-3.45%) ⬇️
include/graaflib/algorithm/graph_traversal.h 100.00% <100.00%> (ø)
include/graaflib/algorithm/shortest_path.tpp 100.00% <100.00%> (ø)
test/graaflib/algorithm/graph_traversal_test.cpp 100.00% <100.00%> (ø)
test/graaflib/algorithm/shortest_path_test.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bobluppes bobluppes marked this pull request as draft August 8, 2023 19:47
@bobluppes bobluppes force-pushed the reuse-traversal-in-other-algorithms branch from c082620 to dda13ba Compare August 9, 2023 19:09
@bobluppes bobluppes marked this pull request as ready for review August 9, 2023 19:19
@bobluppes bobluppes added breaking-change A change which changes the public API refactor A change which does not change any behavior labels Aug 9, 2023
@bobluppes bobluppes merged commit 38b5e3b into main Aug 9, 2023
8 checks passed
@bobluppes bobluppes deleted the reuse-traversal-in-other-algorithms branch August 9, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A change which changes the public API refactor A change which does not change any behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant