-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bellman-Ford without negative weight cycle detection #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there! Thank you for creating your first pull-request on the Graaf library :)
Hi @ndcroos, thank you for your contribution! Looking at the CI, it seems the For the tests, it seems that some of the new tests either have a failing assert or a segfault. Maybe you could already take a look at this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good already, thanks for working on this!
Some minor comments, and an issue with the handling of the edge weights. I just checked locally and I think adjusting the weight handling should fix the failing tests.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
- Coverage 99.74% 99.67% -0.07%
==========================================
Files 23 23
Lines 1158 1226 +68
==========================================
+ Hits 1155 1222 +67
- Misses 3 4 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for contributing 🚀
I created #76 to keep track of the negative weight cycle detection.
See #55
This PR attempts to covers all subtasks, except test coverage of at least 95%.
Documentation is a short description for now.
Test cases are now taken from those for Dijkstra's shortest paths method.