DOCS DFS cycle detection #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Hromz
commented
Sep 14, 2023
Hromz
commented
- Short description
- Potential uses
- Limitation
- Syntax
- Optional
Corrected trailling slashes
- relative railway example - corrected png files
- Added test cases and docs
Added one test
Corrected doc file
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
|
closes #60 |
bobluppes
approved these changes
Sep 17, 2023
Comment on lines
7
to
8
|
|
There was a problem hiding this comment.
[minor]: It sounds like this is a disadvantage of the algorithm, but I am wondering if negative weight cycles would ever influence cycle detection. I would argue the algorithm does work for weighted graphs, but the edge weight will simply not be considered 🙈
What do you think about this?
Suggested change
| The algorithm doesn't work on edges with weight and therefore cannot be used for negative weight cycles. | |
| The algorithm can be used to detect cycles in the structure of a graph, as it does not consider edge weights. | |
There was a problem hiding this comment.
I agree that your suggestion is more correct and a bit more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.