Move cov

bobsh · May 29, 2018 · fe2f691 · fe2f691
1 parent b57b4f7
commit fe2f691
Show file tree

Hide file tree

Showing 6 changed files with 39 additions and 43 deletions.
diff --git a/src/Models/Core/MainModule/UI/Components/AssetItem.spec.lua b/src/Models/Core/MainModule/UI/Components/AssetItem.spec.lua
@@ -1,3 +1,5 @@
+local Roact = require(script.Parent.Parent.Parent.lib.Roact)
+
 return function()
     local AssetItem = require(script.Parent.AssetItem)
 
@@ -6,18 +8,11 @@ return function()
             expect(AssetItem).to.be.ok()
         end)
 
-        it("should init", function()
-            --- @TODO we currently can't emulate marketplace service
-            expect(function()
-                AssetItem:init()
-            end).to.throw()
-        end)
-
-        it("should render", function()
-            --- @TODO we need init to work first
-            expect(function()
-                AssetItem:render()
-            end).to.throw()
+        --- @TODO breaks trying to get MarketplaceService
+        itSKIP("should mount and unmount", function()
+            local d = Roact.createElement(AssetItem)
+            local h = Roact.mount(d)
+            Roact.unmount(h)
         end)
     end)
 end
diff --git a/src/Models/Core/MainModule/UI/Components/AssetsWidget.spec.lua b/src/Models/Core/MainModule/UI/Components/AssetsWidget.spec.lua
@@ -1,3 +1,5 @@
+local Roact = require(script.Parent.Parent.Parent.lib.Roact)
+
 return function()
     local AssetsWidget = require(script.Parent.AssetsWidget)
 
@@ -6,14 +8,13 @@ return function()
             expect(AssetsWidget).to.be.ok()
         end)
 
-        it("should new ok", function()
-            expect(AssetsWidget:init({
+        --- @TODO needs support for UITextSizeConstrainer in lemur
+        itSKIP("should mount and unmount", function()
+            local d = Roact.createElement(AssetsWidget, {
                 Plugin = "foo",
-            })).never.to.be.ok()
-        end)
-
-        it("should render", function()
-            expect(AssetsWidget:render()).to.be.ok()
+            })
+            local h = Roact.mount(d)
+            Roact.unmount(h)
         end)
     end)
 end
diff --git a/src/Models/Core/MainModule/UI/Components/ConfigurationWidget.spec.lua b/src/Models/Core/MainModule/UI/Components/ConfigurationWidget.spec.lua
@@ -1,3 +1,5 @@
+local Roact = require(script.Parent.Parent.Parent.lib.Roact)
+
 return function()
     local ConfigurationWidget = require(script.Parent.ConfigurationWidget)
 
@@ -6,12 +8,10 @@ return function()
             expect(ConfigurationWidget).to.be.ok()
         end)
 
-        it("should init", function()
-            expect(ConfigurationWidget:init({})).never.to.be.ok()
-        end)
-
-        it("should render", function()
-            expect(ConfigurationWidget:render()).to.be.ok()
+        it("should mount and unmount", function()
+            local d = Roact.createElement(ConfigurationWidget)
+            local h = Roact.mount(d)
+            Roact.unmount(h)
         end)
     end)
 end
diff --git a/src/Models/Core/MainModule/UI/Components/Dropdown.lua b/src/Models/Core/MainModule/UI/Components/Dropdown.lua
@@ -27,7 +27,6 @@ function Dropdown:render()
 			BorderSizePixel = 0,
 			Text = item,
 			Size = UDim2.new(1, 0, 0, 20),
-			ZIndex = 5,
 
 			[Roact.Event.MouseButton1Click] = function(_)
 				if self.state.ChangeFn ~= nil then
@@ -45,7 +44,6 @@ function Dropdown:render()
 	return c("TextButton", {
 		Size = UDim2.new(0, 200, 0, 30),
 		Text = "",
-		ZIndex = 5,
 
 		[Roact.Event.MouseButton1Click] = function(_)
 			self:setState({
@@ -70,8 +68,6 @@ function Dropdown:render()
 			Text = self.state.CurrentItem or "select an item",
 			Font = Enum.Font.SourceSans,
 			TextSize = 18,
-			TextScaled = true,
-			ZIndex = 6,
 		}, {
 			c("UITextSizeConstraint", {
 				MaxTextSize = 18,
@@ -81,7 +77,6 @@ function Dropdown:render()
 			Visible = self.state.Open,
 			Size = UDim2.new(1, 0, 0, 100),
 			Position = UDim2.new(0, 0, 1, 0),
-			ZIndex = 5,
 		}, {
 			c("UIListLayout"),
 			unpack(items),

diff --git a/src/Models/Core/MainModule/UI/Components/Dropdown.spec.lua b/src/Models/Core/MainModule/UI/Components/Dropdown.spec.lua
@@ -1,3 +1,5 @@
+local Roact = require(script.Parent.Parent.Parent.lib.Roact)
+
 return function()
     local Dropdown = require(script.Parent.Dropdown)
 
@@ -6,12 +8,13 @@ return function()
             expect(Dropdown).to.be.ok()
         end)
 
-        it("should new ok", function()
-            expect(Dropdown:init({})).never.to.be.ok()
-        end)
-
-        it("should render", function()
-            expect(Dropdown:render()).to.be.ok()
+        --- @TODO Support UITextSizeConstraint in lemur
+        itSKIP("should mount and unmount", function()
+            local d = Roact.createElement(Dropdown, {
+                Items = {"foo"},
+            })
+            local h = Roact.mount(d)
+            Roact.unmount(h)
         end)
     end)
 end
diff --git a/src/Models/Core/MainModule/UI/Components/TextLabel.spec.lua b/src/Models/Core/MainModule/UI/Components/TextLabel.spec.lua
@@ -1,3 +1,5 @@
+local Roact = require(script.Parent.Parent.Parent.lib.Roact)
+
 return function()
     local TextLabel = require(script.Parent.TextLabel)
 
@@ -6,13 +8,13 @@ return function()
             expect(TextLabel).to.be.ok()
         end)
 
-        it("should new ok", function()
-            expect(TextLabel:init({})).never.to.be.ok()
-        end)
-
-        it("should render", function()
-            expect(TextLabel:render()).to.be.ok()
+        it("should mount and unmount", function()
+            local d = Roact.createElement(TextLabel, {
+                Size = UDim2.new(0,0,0,0),
+                Text = "foo",
+            })
+            local h = Roact.mount(d)
+            Roact.unmount(h)
         end)
-
     end)
 end