FSCK spurious logging #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't a particularly nice solution, but currently the delete handler is really very dumb. It parses the HTTP response _just_ to get the error code, and leaves any extra headers on the socket. This means that with keepalive connections, subsequent requests will end up trying to read in the headers for previous requests, which makes everything go horribly wrong. The proper fix to this would be to use a proper HTTP client here, rather than a horrible hack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FSCK logs things back to the parent with 'debug Fixed FID XXXXX\n\r\n
This doesn't match the expected regex, and therefore gets split into two commands, which doesn't work as expected.
I have fixed both the spurious \n here, and also the fact that debug can log messages with \n in it.