RT76037: fix Win32 tests failures and EOL issues in t/12-fail.t #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the destination for &2 must be the same as &1 (2>&1), &1 must be redirected before &2 is redirected. This is not Win32 specific.
Refactor common test code in sub run_ok(). Add test for exit code. Fix check of output. Some tests still fail on Win32.
Fix almost all tests on Win32 by NEVER using raw ^M. The rule: DO NOT USE RAW ^M IN SOURCE CODE. That's not portable! Avoiding those problems is the point of disallowing ^M with Test:EOL. I can't understand why the Test::EOL maintainers didn't apply that rule to themselves. Test 'make_bad_file_3' is so broken that I don't understand what it is supposed to do, so I just translated raw ^M to "\r" for now.
Yes, 12-fail.t was so broken that it had trailing spaces...
To avoid an other shame (see commit 1ec979a) and ensure future Win32 portability, apply all Test::EOL strictures on ourself.
Cleanup the the last failing test on Win32: 'bad_file_3' generated file is now a pure Win32 file (without the fancy crazy \r it had before). The failure is now expected at line 1, instead of line 9 as the first line with \r is line 1. (I don't understand why Test::EOL was supposed to detect only fancy multiple \r instead of *any*). Now, all tests pass on Win32 (RT#76037)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serie of patches fixes major flaws in how t/12-fail.t, so that the code is now portable on Win32 and trailing ^M and spaces are fixed.
https://rt.cpan.org/Ticket/Display.html?id=76037
The major issue in
t/12-fail.twas that raw^Mwere used. However perl on Win32 eats thoses, so the generated files that were erroneous were not, and so tested files had not the issue that the test expected. The point ofTest::EOLis to avoid^Min files. This is not just for cosmetic reasons. This is also to avoid such issues. So commit c0662b4 cleans up ^M at EOL and replaces them with "\r" that are expanded by Perl.Another issue was that
t/12-fail.thad trailing spaces. What a shame! And due to the first issue, trailing spaces check was disabled!So now the sources are EOL clean and this is enforced by using Test::EOL on itself.