Nice step further on :)

bobtfish · Mar 21, 2008 · 11c3734 · 11c3734
1 parent 9d0d67f
commit 11c3734
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/Todo b/Todo
@@ -1,5 +1,6 @@
 Todo pre 1.0.18:
-    . Tests for ignoring stuff.. What happens if I have, say <div /><div id="2">foobar</div> on a line?
+    . Think of more mental test cases for HTML Block hashing tests?
+    . Clean up constructor / initialisation and markdown routine properly.
     . Add tests for entity declarations, doctypes and other things that we find?
     . Make Markdown.pl and MultiMarkdown.pl warn if unexpected options are 
       used, and also have docs on what options are available. Expose the other
@@ -16,7 +17,6 @@ Todo pre 1.0.18:
     . Merge latest MultiMarkdown work? http://groups.google.com/group/multimarkdown/t/4a4210b359065bed
 
 Todo pre 1.0.19:
-    . Clean up constructor / initialisation and markdown routine properly.
     . http://rt.cpan.org/Ticket/Display.html?id=33443
     . More tests in t/15inlinehtmldoesnoturnoffmarkdown.t, I bet turning this 
       feature on breaks things.

diff --git a/lib/Text/Markdown.pm b/lib/Text/Markdown.pm
@@ -360,6 +360,14 @@ sub _HashHTMLBlocks {
                 # If we care about tags here, and we find a tag we care about
                 if ($care && ($current_block_end_tag = $block_tags{$token->[2]}) ) {
                     if ($token->[3]) { #Self closing tag
+                        # Old behavior
+                        push(@output, $token);
+                        $care = 0;
+                        $current_block_end_tag = undef;
+                        next;
+
+                        # This would be much nicer, and we'd hash self closing tags correctly!
+                        # See t/39hashhtmlblocks.t
                         push(@collected, $token);
                         $end_tag_run->();
                         next;