Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pimple 2.x has changed to shared-services-by-default, a decision that’s awesome for a DIC, but not as awesome for a general purpose lazy value bucket like we’re using Pimple for. Since this will likely cause problems with apps which use both Ruler and Pimple, I have removed the Pimple dependency and implemented the Pimple 1.x API directly on Context — using Pimple 2.x-flavored code :)
The extend() method has not been ported to Context, as that seems like a side effect of using a DIC as a base class, more than an explicit feature for the Context. But I’m happy to be proven wrong if someone really needs it.
cc: @jwage @ludicruz Thoughts?