Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0 compatibility - deprecated warnings #385

Closed
jms212004 opened this issue Jan 7, 2022 · 1 comment
Closed

PHP 8.0 compatibility - deprecated warnings #385

jms212004 opened this issue Jan 7, 2022 · 1 comment

Comments

@jms212004
Copy link

Hi,
when i scan with
phpcs -p . --standard=PHPCompatibility --runtime-set testVersion 8.0 --extensions=php

Return:
FILE: mustache/Mustache/Tokenizer.php

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE

102 | WARNING | INI directive 'mbstring.func_overload' is deprecated since PHP 7.2 and removed since PHP 8.0

Best regard

@bobthecow
Copy link
Owner

Thanks for reporting! The check has to stay (because Mustache works with versions of PHP that still support it) but the whole thing is wrapped in a check for < PHP 8.0 now, so eventually it'll be completely removed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants