Add configuration file validation #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 11, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Failed to load tslint.json: Invalid "extends" configuration value - could not...
Failed to load tslint.json: Invalid "extends" configuration value - could not require "tslint-config-standard". Review the Node lookup algorithm (https://nodejs.org/api/modules.html#modules_all_together) for the approximate method TSLint uses to find the referenced configuration file.
houndci-bot
reviewed
Sep 12, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Failed to load tslint.json: Invalid "extends" configuration value - could not...
Failed to load tslint.json: Invalid "extends" configuration value - could not require "tslint-config-standard". Review the Node lookup algorithm (https://nodejs.org/api/modules.html#modules_all_together) for the approximate method TSLint uses to find the referenced configuration file.
… into pr-config-validation
houndci-bot
reviewed
Sep 12, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Failed to load tslint.json: Invalid "extends" configuration value - could not...
Failed to load tslint.json: Invalid "extends" configuration value - could not require "tslint-config-standard". Review the Node lookup algorithm (https://nodejs.org/api/modules.html#modules_all_together) for the approximate method TSLint uses to find the referenced configuration file.
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently whenever a configuration file is available, defaults will be applied
and the result is used as-is.
It would be nice if the configuration was validated before use, so that strange
error will not occur due to configuration typing differences.
This PR will do validation for the configuration file and will fail in one place
when the configuration file does not follow the structure defined in TypeScript.