Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated symfony requirements for 5.4. #8

Merged
merged 2 commits into from
Jan 21, 2022
Merged

Updated symfony requirements for 5.4. #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c519945
Updated symfony requirements.
Jan 20, 2022
6a724ef
Changed symfony and twig requirements based upon request.
Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
},
"require": {
"php": ">=5.5.9",
"symfony/framework-bundle": "^3.4",
"symfony/twig-bundle": "^3.4",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still want to support Symfony 4.4 which is LTS and supports bug fixes until Nov 2022. And also, there's Symfony 6 already, we need to allow it as well :)

I'd write constraints as ^4.4|^5.4|^6.0. Could you make this change for both Symfony dependencies, please?

"twig/twig": "^2.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if we want to support legacy versions I mentioned above - bumping twig to the new major version might be too aggressive. I'd rather allow Twig 2.0 or Twig 3.0, i.e. ^2.0|^3.0

"symfony/framework-bundle": "^4.4|^5.4|^6.0",
"symfony/twig-bundle": "^4.4|^5.4|^6.0",
"twig/twig": "^2.0|^3.0"
},
"require-dev": {
"symfony/phpunit-bridge": "^3.4"
Expand Down