Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently handle "default values" for dataset pages #203

Closed
pbeshai opened this issue Jun 9, 2016 · 2 comments
Closed

Consistently handle "default values" for dataset pages #203

pbeshai opened this issue Jun 9, 2016 · 2 comments

Comments

@pbeshai
Copy link
Collaborator

pbeshai commented Jun 9, 2016

Not clear currently if we want to have defaults or not. I think the result of our conversation with HMS was that we didn't want default values if they are coming straight from the dataset page, but to still support contextualized entry via entityId

@vlandham
Copy link
Contributor

vlandham commented Jun 9, 2016

that is what i would like to propose as well.

if we have an :entityId / :entityType we show the best display we can on
initial page load.

If this is not present, we show no defaults - but ensure we have
explanatory text to encourage user interaction.

On leaving dataset page, we clear filters and reset to initial state.

On toggling of viewBy, we do not reset filters - but maintain both during
the duration of time on the page.

Another optional level of refinement:

On toggling of viewBy - if we have not been to that viewBy before and we
have selected an entity (i.e. cell type / receptor) on the previous viewBy,
then we use this selected entity to inform the presentation of data.

On Thu, Jun 9, 2016 at 7:08 AM, Peter Beshai notifications@github.com
wrote:

Not clear currently if we want to have defaults or not. I think the result
of our conversation with HMS was that we didn't want default values if they
are coming straight from the dataset page, but to still support
contextualized entry via entityId


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#203, or mute the thread
https://github.com/notifications/unsubscribe/AAAkmUHIxMCFuqZI5p7mCXuKAtT2mkQxks5qKB5bgaJpZM4IyAv8
.

@vlandham vlandham self-assigned this Jun 9, 2016
@vlandham
Copy link
Contributor

vlandham commented Jun 9, 2016

done in #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants