This repository has been archived by the owner on Nov 23, 2019. It is now read-only.
Add more reports to timebot #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gnarf
commented
Feb 17, 2017
gnarf
commented
tkellen
reviewed
Feb 22, 2017
src/db/time_history.sql
Outdated
| project.short_code, | ||
| to_char(date_trunc('week', timesheet.day), 'YYYY-MM-DD') as week, | ||
| extract(epoch from sum(timesheet.duration)) / 3600 as hours, | ||
| string_agg(timesheet.notes, '; '::text) as notes |
There was a problem hiding this comment.
do you have to cast this to text here? just curious
tkellen
reviewed
Feb 22, 2017
src/db/time_history.sql
Outdated
| @@ -0,0 +1,12 @@ | |||
| SELECT | |||
| project.short_code, | |||
| to_char(date_trunc('week', timesheet.day), 'YYYY-MM-DD') as week, | |||
There was a problem hiding this comment.
Could you do date(timesheet.day)::text?
tkellen
reviewed
Feb 22, 2017
| `${Number(time).toFixed(2)}h`; | ||
|
|
||
| // target - current is "positive" when current < target (which is a negative thing) | ||
| const emoji = val => |
There was a problem hiding this comment.
this is kinda gross but i get it :p
tkellen
reviewed
Feb 22, 2017
src/timebot/commands/weekly.js
Outdated
| behind, | ||
| ratio, | ||
| }) => | ||
| `\`${code}${' '.repeat(10 - code.length)} [${histogramByPercentage(10, ratio)}\`${emoji(behind)}\`${histogramByPercentage(5, ratio - 1)}] ${` ${Math.round(ratio * 100)}`.slice(-3)}% c:${duration(current)} t:${duration(target)} a:${duration(avg)}\`${emoji(target - avg)}` |
There was a problem hiding this comment.
can we lift this into a named function and call it?
tkellen
reviewed
Feb 22, 2017
| behind, | ||
| ratio, | ||
| }) => { | ||
| // use short variables to make the template be one line |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.