Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Html coop update #11

Closed
wants to merge 6 commits into from
Closed

Html coop update #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4090a6e
[html] Update COOP tests
jugglinmike Dec 17, 2019
37a11fa
[html] Test explicitly-set default COOP value
jugglinmike Dec 18, 2019
eeea7d0
fixup! [html] Update COOP tests
jugglinmike Dec 18, 2019
93b58fb
fixup! [html] Update COOP tests
jugglinmike Dec 18, 2019
c99ac17
fixup! [html] Update COOP tests
jugglinmike Dec 19, 2019
1d00f6a
fixup! [html] Update COOP tests
jugglinmike Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions html/cross-origin-opener-policy/coep-navigate-popup.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,12 @@
const channel = title.replace(/ /g,"-");
const navigateHost = site === "same-origin" ? SAME_ORIGIN : SAME_SITE;
const navigateURL = `${navigateHost.origin}/html/cross-origin-opener-policy/resources/coop-coep.py?coop=${variant.coop}&coep=${variant.coep}&channel=${channel}`;
const opener = site === "same-origin" ? variant.opener : false;
const opener = site === "same-origin" ? variant.opener : true;

async_test(t => {
// For each test we open a COOP: same-origin/COEP: require-corp document in a popup and then
// navigate that to either a same-origin or same-site document whose COOP and COEP are set as
// navigate that to either a same-origin or "same-site" (a historical value which today should
// be equivalent to "unsafe-none") document whose COOP and COEP are set as
// per the top-most array. We then verify that this document has the correct opener for its
// specific setup.
url_test(t, `${SAME_ORIGIN.origin}/html/cross-origin-opener-policy/resources/coop-coep.py?coop=same-origin&coep=require-corp&navigate=${encodeURIComponent(navigateURL)}`, channel, opener);
Expand Down
6 changes: 3 additions & 3 deletions html/cross-origin-opener-policy/coep.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@
coop_coep_test(t, SAME_ORIGIN, variant.coop, variant.coep, variant.title.replace(/ /g,"-"), variant.opener);
}, `Same-origin ${variant.title}`);

// This seems useful to test, CROSS_SITE is probably too redundant though.
// "same-site" is a historical value and should be interpreted as "unsafe-none"
async_test(t => {
coop_coep_test(t, SAME_SITE, variant.coop, variant.coep, `same-site-${variant.title.replace(/ /g,"-")}`, false);
}, `Same-site ${variant.title}`);
coop_coep_test(t, SAME_SITE, variant.coop, variant.coep, `same-site-${variant.title.replace(/ /g,"-")}`, true);
}, `historical: "same-site" ${variant.title}`);
});

test(() => {
Expand Down
2 changes: 1 addition & 1 deletion html/cross-origin-opener-policy/coop-navigated-popup.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!doctype html>
<title>Cross-Origin-Opener-Policy: a navigated popup</title>
<!-- In particular this is different from coep-navigate-popup.https.html as this document initiates
the navigation (and uses unsafe-allow-outgoing and no COEP as without that it cannot be
the navigation (and uses same-origin-allow-popups and no COEP as without that it cannot be
observed). COOP should work identically, but implementations might have used the wrong
authority. -->
<script src=/resources/testharness.js></script>
Expand Down
2 changes: 1 addition & 1 deletion html/cross-origin-opener-policy/coop-navigated-popup.https.html.headers
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Cross-Origin-Opener-Policy: same-origin unsafe-allow-outgoing
Cross-Origin-Opener-Policy: same-origin-allow-popups
43 changes: 43 additions & 0 deletions .../cross-origin-opener-policy/historical/popup-same-origin-unsafe-allow-outgoing.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<!doctype html>
<meta charset=utf-8>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<script src="/common/get-host-info.sub.js"></script>
<script src="../resources/common.js"></script>

<div id=log></div>
<script>

let tests = [
// popup Origin, popup COOP, expect opener
[SAME_ORIGIN, "", true],
[SAME_ORIGIN, "unsafe-none", true],
[SAME_ORIGIN, "jibberish", true],
[SAME_ORIGIN, "same-site", true], // historical value
[SAME_ORIGIN, "same-site unsafe-allow-outgoing", true], // historical value
[SAME_ORIGIN, "same-origin unsafe-allow-outgoing", true], // historical value
[SAME_ORIGIN, "same-origin", false],
[SAME_ORIGIN, "same-origin-allow-popups", false],

[SAME_SITE, "", true],
[SAME_SITE, "unsafe-none", true],
[SAME_SITE, "jibberish", true],
[SAME_SITE, "same-site", true], // historical value
[SAME_SITE, "same-site unsafe-allow-outgoing", true], // historical value
[SAME_SITE, "same-origin unsafe-allow-outgoing", true], // historical value
[SAME_SITE, "same-origin", false],
[SAME_SITE, "same-origin-allow-popups", false],

[CROSS_ORIGIN, "", true],
[CROSS_ORIGIN, "unsafe-none", true],
[CROSS_ORIGIN, "jibberish", true],
[CROSS_ORIGIN, "same-site", true], // historical value
[CROSS_ORIGIN, "same-site unsafe-allow-outgoing", true], // historical value
[CROSS_ORIGIN, "same-origin unsafe-allow-outgoing", true], // historical value
[CROSS_ORIGIN, "same-origin", false],
[CROSS_ORIGIN, "same-origin-allow-popups", false],
];

run_coop_tests("same-origin unsafe-allow-outgoing", tests);

</script>
0 ...-unsafe-allow-outgoing.https.html.headers → ...-unsafe-allow-outgoing.https.html.headers
View file
Open in desktop
File renamed without changes.
43 changes: 43 additions & 0 deletions html/cross-origin-opener-policy/historical/popup-same-site-unsafe-allow-outgoing.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<!doctype html>
<meta charset=utf-8>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<script src="/common/get-host-info.sub.js"></script>
<script src="../resources/common.js"></script>

<div id=log></div>
<script>

let tests = [
// popup Origin, popup COOP, expect opener
[SAME_ORIGIN, "", true],
[SAME_ORIGIN, "unsafe-none", true],
[SAME_ORIGIN, "jibberish", true],
[SAME_ORIGIN, "same-site", true], // historical value
[SAME_ORIGIN, "same-site unsafe-allow-outgoing", true], // historical value
[SAME_ORIGIN, "same-origin unsafe-allow-outgoing", true], // historical value
[SAME_ORIGIN, "same-origin", false],
[SAME_ORIGIN, "same-origin-allow-popups", false],

[SAME_SITE, "", true],
[SAME_SITE, "unsafe-none", true],
[SAME_SITE, "jibberish", true],
[SAME_SITE, "same-site", true], // historical value
[SAME_SITE, "same-site unsafe-allow-outgoing", true], // historical value
[SAME_SITE, "same-origin unsafe-allow-outgoing", true], // historical value
[SAME_SITE, "same-origin", false],
[SAME_SITE, "same-origin-allow-popups", false],

[CROSS_ORIGIN, "", true],
[CROSS_ORIGIN, "unsafe-none", true],
[CROSS_ORIGIN, "jibberish", true],
[CROSS_ORIGIN, "same-site", true], // historical value
[CROSS_ORIGIN, "same-site unsafe-allow-outgoing", true], // historical value
[CROSS_ORIGIN, "same-origin unsafe-allow-outgoing", true], // historical value
[CROSS_ORIGIN, "same-origin", false],
[CROSS_ORIGIN, "same-origin-allow-popups", false],
];

run_coop_tests("same-site unsafe-allow-outgoing", tests);

</script>
0 ...-unsafe-allow-outgoing.https.html.headers → ...-unsafe-allow-outgoing.https.html.headers
View file
Open in desktop
File renamed without changes.
43 changes: 43 additions & 0 deletions html/cross-origin-opener-policy/historical/popup-same-site.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<!doctype html>
<meta charset=utf-8>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<script src="/common/get-host-info.sub.js"></script>
<script src="../resources/common.js"></script>

<div id=log></div>
<script>

let tests = [
// popup Origin, popup COOP, expect opener
[SAME_ORIGIN, "", true],
[SAME_ORIGIN, "unsafe-none", true],
[SAME_ORIGIN, "jibberish", true],
[SAME_ORIGIN, "same-site", true], // historical value
[SAME_ORIGIN, "same-site unsafe-allow-outgoing", true], // historical value
[SAME_ORIGIN, "same-origin unsafe-allow-outgoing", true], // historical value
[SAME_ORIGIN, "same-origin", false],
[SAME_ORIGIN, "same-origin-allow-popups", false],

[SAME_SITE, "", true],
[SAME_SITE, "unsafe-none", true],
[SAME_SITE, "jibberish", true],
[SAME_SITE, "same-site", true], // historical value
[SAME_SITE, "same-site unsafe-allow-outgoing", true], // historical value
[SAME_SITE, "same-origin unsafe-allow-outgoing", true], // historical value
[SAME_SITE, "same-origin", false],
[SAME_SITE, "same-origin-allow-popups", false],

[CROSS_ORIGIN, "", true],
[CROSS_ORIGIN, "unsafe-none", true],
[CROSS_ORIGIN, "jibberish", true],
[CROSS_ORIGIN, "same-site", true], // historical value
[CROSS_ORIGIN, "same-site unsafe-allow-outgoing", true], // historical value
[CROSS_ORIGIN, "same-origin unsafe-allow-outgoing", true], // historical value
[CROSS_ORIGIN, "same-origin", false],
[CROSS_ORIGIN, "same-origin-allow-popups", false],
];

run_coop_tests("same-site", tests);

</script>
0 ...policy/popup-same-site.https.html.headers → ...orical/popup-same-site.https.html.headers
View file
Open in desktop
File renamed without changes.
37 changes: 0 additions & 37 deletions html/cross-origin-opener-policy/popup-none.https.html
View file
Open in desktop

This file was deleted.

43 changes: 43 additions & 0 deletions html/cross-origin-opener-policy/popup-same-origin-allow-popups.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<!doctype html>
<meta charset=utf-8>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<script src="/common/get-host-info.sub.js"></script>
<script src="resources/common.js"></script>

<div id=log></div>
<script>

let tests = [
// popup Origin, popup COOP, expect opener
[SAME_ORIGIN, "", true],
[SAME_ORIGIN, "unsafe-none", true],
[SAME_ORIGIN, "jibberish", true],
[SAME_ORIGIN, "same-site", true], // historical value
[SAME_ORIGIN, "same-site unsafe-allow-outgoing", true], // historical value
[SAME_ORIGIN, "same-origin unsafe-allow-outgoing", true], // historical value
[SAME_ORIGIN, "same-origin", false],
[SAME_ORIGIN, "same-origin-allow-popups", true],

[SAME_SITE, "", true],
[SAME_SITE, "unsafe-none", true],
[SAME_SITE, "jibberish", true],
[SAME_SITE, "same-site", true], // historical value
[SAME_SITE, "same-site unsafe-allow-outgoing", true], // historical value
[SAME_SITE, "same-origin unsafe-allow-outgoing", true], // historical value
[SAME_SITE, "same-origin", false],
[SAME_SITE, "same-origin-allow-popups", false],

[CROSS_ORIGIN, "", true],
[CROSS_ORIGIN, "unsafe-none", true],
[CROSS_ORIGIN, "jibberish", true],
[CROSS_ORIGIN, "same-site", true], // historical value
[CROSS_ORIGIN, "same-site unsafe-allow-outgoing", true], // historical value
[CROSS_ORIGIN, "same-origin unsafe-allow-outgoing", true], // historical value
[CROSS_ORIGIN, "same-origin", false],
[CROSS_ORIGIN, "same-origin-allow-popups", false],
];

run_coop_tests("same-origin-allow-popups", tests);

</script>
1 change: 1 addition & 0 deletions html/cross-origin-opener-policy/popup-same-origin-allow-popups.https.html.headers
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Cross-Origin-Opener-Policy: same-origin-allow-popups
37 changes: 0 additions & 37 deletions html/cross-origin-opener-policy/popup-same-origin-unsafe-allow-outgoing.https.html
View file
Open in desktop

This file was deleted.

24 changes: 15 additions & 9 deletions html/cross-origin-opener-policy/popup-same-origin.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,25 +11,31 @@
let tests = [
// popup Origin, popup COOP, expect opener
[SAME_ORIGIN, "", false],
[SAME_ORIGIN, "unsafe-none", false],
[SAME_ORIGIN, "jibberish", false],
[SAME_ORIGIN, "same-site", false],
[SAME_ORIGIN, "same-site unsafe-allow-outgoing", false],
[SAME_ORIGIN, "same-site", false], // historical value
[SAME_ORIGIN, "same-site unsafe-allow-outgoing", false], // historical value
[SAME_ORIGIN, "same-origin unsafe-allow-outgoing", false], // historical value
[SAME_ORIGIN, "same-origin", true],
[SAME_ORIGIN, "same-origin unsafe-allow-outgoing", false],
[SAME_ORIGIN, "same-origin-allow-popups", false],

[SAME_SITE, "", false],
[SAME_SITE, "unsafe-none", false],
[SAME_SITE, "jibberish", false],
[SAME_SITE, "same-site", false],
[SAME_SITE, "same-site unsafe-allow-outgoing", false],
[SAME_SITE, "same-site", false], // historical value
[SAME_SITE, "same-site unsafe-allow-outgoing", false], // historical value
[SAME_SITE, "same-origin unsafe-allow-outgoing", false], // historical value
[SAME_SITE, "same-origin", false],
[SAME_SITE, "same-origin unsafe-allow-outgoing", false],
[SAME_SITE, "same-origin-allow-popups", false],

[CROSS_ORIGIN, "", false],
[CROSS_ORIGIN, "unsafe-none", false],
[CROSS_ORIGIN, "jibberish", false],
[CROSS_ORIGIN, "same-site", false],
[CROSS_ORIGIN, "same-site unsafe-allow-outgoing", false],
[CROSS_ORIGIN, "same-site", false], // historical value
[CROSS_ORIGIN, "same-site unsafe-allow-outgoing", false], // historical value
[CROSS_ORIGIN, "same-origin unsafe-allow-outgoing", false], // historical value
[CROSS_ORIGIN, "same-origin", false],
[CROSS_ORIGIN, "same-origin unsafe-allow-outgoing", false],
[CROSS_ORIGIN, "same-origin-allow-popups", false],
];

run_coop_tests("same-origin", tests);
Expand Down
37 changes: 0 additions & 37 deletions html/cross-origin-opener-policy/popup-same-site-unsafe-allow-outgoing.https.html
View file
Open in desktop

This file was deleted.

Loading