Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for password hash attributes #39

Merged
merged 1 commit into from
Aug 27, 2016
Merged

Conversation

tcsalameh
Copy link
Contributor

This adds two attributes used to specify the how LDAP hashes passwords.
password_hash sets the type of hash that the LDAP server will use, while
password_crypt_salt_format sets the format of the salt.

This adds two attributes used to specify the how LDAP hashes passwords.
password_hash sets the type of hash that the LDAP server will use, while
password_crypt_salt_format sets the format of the salt.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 55.0% when pulling ae1e3cc on tcsalameh:pw-hash into 0cb2567 on bodgit:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 55.0% when pulling ae1e3cc on tcsalameh:pw-hash into 0cb2567 on bodgit:master.

@bodgit
Copy link
Owner

bodgit commented Aug 26, 2016

Cool, I'll commit this with a few tweaks. Notably I recently found these additional password mechanisms so I'll amend the regex to handle these.

@bodgit bodgit self-assigned this Aug 26, 2016
@bodgit bodgit added this to the v1.3.0 milestone Aug 26, 2016
@tcsalameh
Copy link
Contributor Author

Thanks! I didn't know that OpenLDAP supported those additional mechanisms, good to know.

@bodgit bodgit merged commit ae1e3cc into bodgit:master Aug 27, 2016
@bodgit
Copy link
Owner

bodgit commented Aug 27, 2016

They are however, a bit of a PITA to build. You basically need to have the full OpenLDAP source unpacked and ./configure'd before you can build them. I was looking at how easy it would be to build some packages for these extra password modules and it looks like I'd have to duplicate most of the RPM spec.

@bodgit
Copy link
Owner

bodgit commented Aug 30, 2016

I managed to get SHA2 support built and tested so I've added some additional parameters that allow you to pull in additional packages for non-standard hashing schemes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants