Remove all class absolute name scopes #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add augeas_core to fixtures * Fix yp::serv default for `$slaves` to fix tests as well as an error with `size()` if `$slaves` is `undef` * Fix some chained tests that were failing
|
I'm going to convert this module to use PDK and part of that will run lint and rubocop over the module. I'll try and use this PR and then fix anything else that gets flagged. |
|
If you have a branch with PDK changes, I can change the base on this PR to that branch so it can be merged there instead of the default branch. |
|
I've fixed everything to the point the lint checks should pass. There are other bits that I can see are cosmetically wrong but I'd rather enhance the various lint plugins to flag them so it saves me the hassle in other modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.