Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type hint the create and get methods #10

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Conversation

YSaxon
Copy link

@YSaxon YSaxon commented May 9, 2023

Just some very minor type hints to make it more obvious how to use the methods

@YSaxon
Copy link
Author

YSaxon commented May 17, 2023

I'm confused by the failure here. My pylint runs fine..

@bodik
Copy link
Owner

bodik commented Jun 8, 2023

I'm confused by the failure here. My pylint runs fine..

have you installed dependencies via requirements-dev.txt or .lock ? according to python-fido2 git tree, the CredentialCreationOptions were added at 1.1.0

most likely we'll need to bump its version to resolve the issue

@bodik
Copy link
Owner

bodik commented Jun 8, 2023

turns out that setup.py uses fido2>1.0 and fido2<2.0 uses latest 1.1.1 where the required types are present, but requirements-dev.lock used by CI uses fixed version 1.0.0 and hence the confustion

i'll try to resolve it in PR branch on top of devel before merging (my first time doing that, so it might require a bit of elaboration)

@bodik bodik changed the base branch from master to devel June 8, 2023 20:27
@bodik bodik merged commit 0fea87a into bodik:devel Jun 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants