This repository has been archived by the owner on May 13, 2020. It is now read-only.
Refactor elixir checker to accept phoenix projects #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The elixir checker uses the `mix compile` command. This command has to be executed from the root of the project containing the `mix.exs` config file. The commit allow the checker to find this root directory and launch the command from here, giving access to all libs dependencies. This is kind of a hack. An issue exist in the flycheck project: flycheck/flycheck#312
|
This approach does not seem to comply with flycheck design and best practices. I withdraw it. |
|
Shame. Been struggling with this myself - the only reasonable fix seems to be to get mix to do the right thing. :( |
|
They have a PR which should solve the issue. It should be accepted within few weeks (months?) Meanwhile, I use the functions I proposed, but as it is kind of a hack, I moved them to |
|
Another solution could be to use Maybe a road to try for the week-end ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The elixir checker uses the
mix compilecommand. This commandhas to be executed from the root of the project containing
the
mix.exsconfig file.The commit allows the checker to find this root directory and launch
the command from here, giving access to all libs dependencies.
This is kind of a hack. An issue exist in the flycheck project:
flycheck/flycheck#312
Any feedback and improvement are more than welcome.