Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #![no_std] builds. #18

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Fix #![no_std] builds. #18

merged 1 commit into from
Jul 1, 2021

Conversation

okready
Copy link
Contributor

@okready okready commented Dec 22, 2020

Closes #17.

This adds use statements to import alloc types such as String, Box, and ToString manually to resolve #![no_std] build issues.

I also have a separate commit with an update to the GitHub Actions CI configuration to add cargo check and Clippy tests with std disabled. If it's acceptable, I can combine it with this PR or create a separate PR with it once this is merged.

#![no_std] builds do not import alloc crate types such as String or Box
into the default scope automatically, requiring them to be imported
manually. This commit adds explicit use statements for those types to
resolve build failures when building with the "std" feature disabled.

Closes bodil#17.
@schungx
Copy link

schungx commented Mar 29, 2021

I wonder if this PR will be merged soon? SmartString is a problem to use in no-std environments.

Right now I'm pulling from @okready 's branch instead of crates.io.

@bodil bodil merged commit 019e1f8 into bodil:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure when disabling std feature
3 participants