Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows port of the msprime functionality #102

Merged
merged 3 commits into from Aug 8, 2022
Merged

Windows port of the msprime functionality #102

merged 3 commits into from Aug 8, 2022

Conversation

bodkan
Copy link
Owner

@bodkan bodkan commented Aug 7, 2022

A student in the department (complete newbie to popgen and simulations) has a Windows laptop and wants to run some simple coalescent simulations. This should hopefully unlock the option to run Python-based msprime simulations in slendr.

Running SLiM in slendr requires working with the OS command-line and slendr currently does it using unix terminal under the hood. Porting this to Windows will be more work (it's been > 10 years since I touched cmd.exe on a Windows machine), but at least the Windows Python/msprime port should be relatively straightforward, so let's focus on that here.

@bhaller
Copy link
Collaborator

bhaller commented Aug 7, 2022

You might consider just recommending that people do this sort of thing under the WSL when on Windows. SLiM runs under the WSL just fine, including SLiMgui; chapter 2 of the manual has install instructions for that configuration. But of course if it worked on native Windows too, that would be nice.

@codecov-commenter
Copy link

Codecov Report

Merging #102 (d9312a3) into main (6154f94) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   81.94%   81.90%   -0.05%     
==========================================
  Files           6        6              
  Lines        2886     2879       -7     
==========================================
- Hits         2365     2358       -7     
  Misses        521      521              
Impacted Files Coverage Δ
R/compilation.R 89.71% <100.00%> (-0.14%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bodkan
Copy link
Owner Author

bodkan commented Aug 8, 2022

Yeah, that is definitely a good option. I've been hesitant to recommend something like that officially, simply because I have no way of testing things myself. In fact, I don't even have access to a Windows machine. Perhaps I should finally look for a reasonable/free virtualization option for macOS.

I will probably wait for someone to really need this and then work with them to sort a full Windows port together. It would be nice to have the possibility to use slendr/SLiM without WSL because that would make the package truly multiplatform.

@bodkan bodkan merged commit 0fea987 into main Aug 8, 2022
@bhaller
Copy link
Collaborator

bhaller commented Aug 8, 2022

Yeah, that is definitely a good option. I've been hesitant to recommend something like that officially, simply because I have no way of testing things myself. In fact, I don't even have access to a Windows machine. Perhaps I should finally look for a reasonable/free virtualization option for macOS.

I will probably wait for someone to really need this and then work with them to sort a full Windows port together. It would be nice to have the possibility to use slendr/SLiM without WSL because that would make the package truly multiplatform.

This is much the same position I am in with SLiM; I have no Windows machine, and no desire to learn how to do software development on Windows, so I waited until someone came along who wanted to volunteer to do the port. :->

@bodkan bodkan deleted the windows-port branch August 20, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants