Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for the possibility to have non-spatial populations in an otherwise spatial model #121

Merged
merged 46 commits into from
Feb 2, 2023

Conversation

bodkan
Copy link
Owner

@bodkan bodkan commented Jan 31, 2023

It might be (?) occasionally (?) useful (?) to have populations in a spatial model which do not have a well-defined spatial boundary. For instance, if we don't know or don't care about the spatial location of some population in the model (but we do know this or care about this for other populations), or if we want to have a "normal" coalescent non-spatial model, but want to some populations in that model annotated with some spatial metadata (not implemented yet, but will be soon). Such models were not valid in the original implementation of slendr.

It turned out that the changes to the compilation process of slendr models and the SLiM back end required to make this possible turned out to be quite minor. This PR implements those changes and adds a new example to the "semi-spatial" demes-based simulations vignette demonstrating this possibility.

@bodkan
Copy link
Owner Author

bodkan commented Feb 2, 2023

Unfortunately, yet another conda breakage occurred while working on this. Took forever to fix things, but at least I used the opportunity to bump up required versions of msprime/tskit/pyslim and Python (3.11) to their latest releases. Again, all of this is a purely internal matter as far the slendr is concerned. Our setup_env() function takes care of everything automatically, even for users who don't even have Python on their systems (reticulate really is incredible).

slendr is now ready for its v0.5 release to CRAN, yay!

@bodkan bodkan merged commit 57aca52 into main Feb 2, 2023
@bodkan bodkan deleted the spatial-nonspatial-mixed-models branch February 2, 2023 10:59
@bodkan bodkan restored the spatial-nonspatial-mixed-models branch February 2, 2023 15:10
@bodkan bodkan deleted the spatial-nonspatial-mixed-models branch February 13, 2023 10:26
@bodkan bodkan restored the spatial-nonspatial-mixed-models branch March 2, 2023 08:37
@bodkan bodkan deleted the spatial-nonspatial-mixed-models branch March 9, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant