attributes lost on name[type='corporate']

[holfordm]

name type="corporate" has lost other attributes (e.g. @ref, @key, @role) on conversion to orgName. Example: Bodley_0065 at <origPlace>.

[jamescummings]

Yeah, same problem as the persName issue, with the same question. I'll treat them alike.

[jamescummings]

Ok, this is done in my script. I notice a related issue where there are lots of <persName> inside <name type="corporate">. I've not found one yet that I would call a person. Am I right that these should just disappear?
i.e.

<name type="corporate" role="formerOwner"><persName>Merton College</persName></name>

become

<orgName role="formerOwner">Merton College</name>

[holfordm]

yes, that is right. <persName> inside <name[type=person] and type=corporate]> and inside <author> is a hangover from Fihrist / cambridge practice.

…

________________________________ From: James Cummings <notifications@github.com> Sent: 25 April 2017 14:33 To: bodleian/tei-tolkien Cc: holfordm; Author Subject: Re: [bodleian/tei-tolkien] attributes lost on name[type='corporate'] (#2) Ok, this is done in my script. I notice a related issue where there are lots of <persName> inside <name type="corporate">. I've not found one yet that I would call a person. Am I right that these should just disappear? i.e. <name type="corporate" role="formerOwner"><persName>Merton College</persName></name> become <orgName role="formerOwner">Merton College</name> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#2 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATThVIV8glp7z2obrmsMm40CsIwf3GF7ks5rzgQ_gaJpZM4NHXdu>.

[jamescummings]

Should I be getting rid of persName inside author? Most of the time there is only a persName (if there is one) in 7 cases it is also got another element there (often title.... which seems weird to me) i.e.

<author ref="http://viaf.org/viaf/99942145">
       <persName>Livy</persName>
       <title>Ab urbe condita</title>
 </author>

Should I try to move title outside of author? i.e.

<author ref="http://viaf.org/viaf/99942145">Livy</author>
<title>Ab urbe condita</title>

[holfordm]

those 7 cases look like errors - can you send me a list, I'll fix them. after that, yes, persName inside author can go.

…

________________________________ From: James Cummings <notifications@github.com> Sent: 25 April 2017 16:01 To: bodleian/tei-tolkien Cc: holfordm; Author Subject: Re: [bodleian/tei-tolkien] attributes lost on name[type='corporate'] (#2) Should I be getting rid of persName inside author? Most of the time there is only a persName (if there is one) in 7 cases it is also got another element there (often title.... which seems weird to me) i.e. <author ref="http://viaf.org/viaf/99942145"> <persName>Livy</persName> <title>Ab urbe condita</title> </author> Should I try to move title outside of author? i.e. <author ref="http://viaf.org/viaf/99942145">Livy</author> <title>Ab urbe condita</title> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#2 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATThVEWicyQHiq8UjRESrT-d26aakqj6ks5rzhi9gaJpZM4NHXdu>.

[jamescummings]

Easy enough to add to the conversion a rule for author elements that have a title that moves it outside, and a rule for title elements inside author elements that makes them (otherwise) vanish. So no worries... just wanted to check it was the right thing to do.

[holfordm]

Might be worth me double checking in case there are other elements in there as well? e.g. note?

[jamescummings]

Notes inside author don't really bother me.... but titles inside author are just nonsensical in my opinion. So I'm running the conversion again with that updated and hopefully the persName and orgName things straightened out.

[holfordm]

I agree. It's just an error where the author tag has got wrapped around more than it should have.

…

________________________________ From: James Cummings <notifications@github.com> Sent: 26 April 2017 10:08 To: bodleian/tei-tolkien Cc: holfordm; Author Subject: Re: [bodleian/tei-tolkien] attributes lost on name[type='corporate'] (#2) Notes inside author don't really bother me.... but titles inside author are just nonsensical in my opinion. So I'm running the conversion again with that updated and hopefully the persName and orgName things straightened out. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#2 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATThVGF1LwZmmYA5B_obKZqyJNopzpaOks5rzxeQgaJpZM4NHXdu>.

[jamescummings]

I believe this is done, so I'm closing it. re-open if it is still a problem.