when using 5.0.x branch, fail on mod files in GCCcore installs on jsc-zen3
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
requested changes
Jan 18, 2024
eb_from_pr_upload_jsc-zen2.sh
Outdated
| @@ -41,6 +41,10 @@ if [ $EB_REPO == "easybuild-easyblocks" ]; then | |||
| repo_pr_arg='--include-easyblocks-from-pr' | |||
| fi | |||
|
|
|||
| if [[ $EB_PREFIX == *"5.0.x"* ]]; then | |||
| export EASYBUILD_FAIL_ON_MOD_FILES_GCCCORE=1 | |||
There was a problem hiding this comment.
@SebastianAchilles We should move this to eb_from_pr_upload_jsc-zen3.sh, and use EB_BRANCH I guess (cfr. #33)
@branfosj Can you look into changing that?
branfosj
changed the title
boegel
changed the title
jsc-zen3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires:
5.0.xinEB_PREFIX(add option to also test other branches on jsc-zen3 #33)