Add support for plasma 6 #13
Comments
|
To be honest, it would be a good idea to rebase this style on upstream Breeze, because that has been getting a lot of love recently and rewriting this to Qt6 in this state doesn't seem like a great idea. |
|
I made a port to QT6 4 months ago. Luwx#200 (comment) |
|
@edpil02 if you open source it or email me a patch (my email is evan (the at goes here) boehs.org) I’m more than happy to merge it here |
|
I planned to send you a patch since my port is based on your repository and I wanted a code review cause I'm not a programmer , after dealing with some qt6 depredications. At the same time klassy developer: https://github.com/paulmcauley/klassy is ready to add lighty options in his code and I think he will accept help. |
|
@edpil02 Could you please publish the source code, or even just a Also I don't see how klassy could be an alternative, as that doesnt currently support qt6 either |
|
I’m considering the possibility of placing a bounty on this. What would people be willing to contribute? |
|
Not that much, but I could consider putting 5$ into it |
|
I'm still spending time reviewing the code because there are still changes in qt6 |
|
Good news, I managed to get my opacity slider to work again. |
|
See the screenshot , qt6ct (i dont use it) seems to see the theme. |
|
That's awesome! btw, qt6ct just exists to make qt handling easier outside of plasma, so it would make sense for you not to be using it |
|
@alba4k . Done . I sent a tarball to Boehs for a merge if it's possible. |
|
I can confirm that I have received the patched tarball, I will review it shortly. |
|
I was wondering Do you know if it would be possible to get control on the AUR package? |
There is already the lightly-boehs-git package on the aur |
|
As the former maintainer of that package, no, there isn't, I've deleted it because the lightly-git package points to this repo. |
|
I see, thanks! Also, why does the -git version have so many extra dependencies? |
That's why i couldn't find it. I thought that the lightly-git was the git version of the original version |
|
@boehs did you manage to start taking a look at their code? sorry to bother 😅 |
|
Briefly. My Linux machine is inaccessible right now so I intend to setup a
VM to test, but I likely won't have anything before next week.
… Message ID: ***@***.***>
|
|
I have opened a PR at #16 so, if you should wish, you can test the code yourself. Aside from testing, I have asked for edpil02's preferred name and email for the commit |
I do not maintain the AUR package. Edit: And at this time I am not interested in doing so. |
|
One question I especially need to answer is if this code is still functional on KDE 5.27. If it's not, a decision needs to be made:
Because I suppose I am now the benevolent dictator, I'm inclined to opt for option A, but I am open to other opinions |
|
How about C? a cmake flag like |
|
@alba4k But I think Boehs is better than me to decide on the right solution and improve the code. |
|
|
|
This is what I said above, I added 1 files I |
My problem while compiling this was that config/ui_lightlyconfigurationui.h was not being generated. |
|
I succesfully compile but getting this I follow all the recomendations like Switched to qt6 branch, added lightlystyleconfig.json to /kstyle/config and pulled CMakeLists.txt, kcm_lightlydecoration.{json,cpp} from the config.tar.gz to kdecoration/config. Cd'd into /build/kdecoration/config/ i executed make and it generated the ui_lightlyconfigurationui.h I'm on KDE Neon This is the output on cmake And this is the output for sudo make install Not sure if it's because the missing optional package. I don't think so because it's optional but I don't have a clue. Help please. Thanks!! |
I followed the steps above exactly except the
|
Just wondering is that the sweet theme you've got there? I recognise the window buttons. That combination with the lightly desktop theme looks so clean I'm def gonna have to try that XD |
I use McVentura Dark for Plasma Style, Ullterly Round Dark solid for window decorations, Tela Circle Dark for icons, ChromeOSKDE Darknes (with some slight modifications) for colors, and for rounded corners I use LightlyShaders plasma6 branch. Some are tuned according to preference, but should be straightforward, otherwise. Hope that helps. |
Thanks I'll have a look at those themes |
|
I am having issues installing lightly on plasma 6. I should have done all the steps shown in this thread. |
|
when i compile config/ui_lightlyconfigurationui.h isn't being generated and i tried doing what someone else above said by going into the make file of that directory and even tho its now generated it still says it cant find the file so anyone know what am i doing wrong? |
|
I can confirm that it compiles successfully and the team works completely fine. |
|
I followed these instructions as best as I could, but I can't make the build/kdecoration/config for the "ui_lightlyconfigurationui.h"
I'm using KDE Neon and based on the type I think it needs kf6-kwindowsystem which I already have installed I cloned the repo and downloaded the files from here, put the files from the tar to kdecoration/config, put the json in kstyle/config, then used the cmake command also from this PR in build/, used make, cd to kdecoration/config and again make and there this error happened. |
|
In my case I did not need to build ui_lightlyconfiguration.h. |
|
I used this cmake build command:
then make and I got this error which I expected based on other replies |
{
fetchFromGitHub,
mkKdeDerivation,
extra-cmake-modules,
kdecoration,
plasma-workspace,
qtbase,
fetchurl,
}:
mkKdeDerivation rec {
pname = "lightly-qt6";
version = "0.4.1";
src = fetchFromGitHub {
owner = "boehs";
repo = "Lightly";
rev = "00ca23447844114d41bfc0d37cf8823202c082e8";
sha256 = "sha256-NpgOcN9sDqgQMjqcfx92bfKohxaJpnwMgxb9MCu9uJM=";
};
patchPhase =
let
config-tar-gz = fetchurl {
url = "https://github.com/boehs/Lightly/files/14445309/config.tar.gz";
sha256 = "sha256-eCIRm2z1+eTBcCCg8Wdt2DfTTbc767Rv+m1LI+t058I=";
};
lightlystyleconfig-json = fetchurl {
url = "https://github.com/boehs/Lightly/files/14444935/lightlystyleconfig.json";
sha256 = "sha256-ORQk0QirDB9dF3RdgmH5sstqQqqSEfOE6lh1YEUz+iM=";
};
in ''
mkdir tmp
cd tmp
tar -xv -f ${config-tar-gz}
cd ..
cp -v tmp/config/CMakeLists.txt kdecoration/config/CMakeLists.txt
cp -v tmp/config/kcm_lightlydecoration.json kdecoration/config/kcm_lightlydecoration.json
cp -v tmp/config/kcm_lightlydecoration.cpp kdecoration/config/kcm_lightlydecoration.cpp
cp -v ${lightlystyleconfig-json} kstyle/config/lightlystyleconfig.json
'';
extraBuildInputs = [
kdecoration
plasma-workspace
extra-cmake-modules
];
}Here's a compiling nix derivation for the qt6 version of lightly. Still testing if it works. (call it like this:) lightly-qt6 = pkgs.kdePackages.callPackage ./apps/lightly-qt6.nix {};EDIT: Can confirm it works. |
|
I followed the instructions, but got an error: Tell me what could be the problem? |
Hi, I'm also on KDE Neon but I can't compile, have you succeeded since then and what steps did you take? EDIT: Finaly have the same : |
|
Hi, Lightly now works on my KDE Neon but I have some display bugs:
|
Not reproducible in Fedora
|
|
Just want to add that everything is working perfectly for me too! In fact, I was seeing some artifacts on qt5 that actually disappeared in qt6+lightly. Is there anything left preventing an aur release? |
|
@alexhulbert lightly-qt6-git with a patch is already on aur and copr. @boehs needs to tag a release at first if you want an actual "release" on aur. There are outstanding bugs though that are present in both luwx and boehs versions. |
Oh my bad, I must have missed that. Thanks! |
|
Sorry yall, I'm immensely busy with various personal things that have cropped up in the past month. I'd still consider this fork maintainedish, I just need to deal with the other stuff first. By the way, I'm mildly interested in adding another maintainer to handle stuff like this, I'll give it more thought soon. Again I'm immensely sorry, I know I said it'd be done a few weeks ago but that's just the way life be sometimes |
I wish I could help with maintaining amazing projects like this one, but I'm currently lacking the skill and even the time to do so. School is keeping me busy, and I am doing my best to get the Abitur, which is a German degree. I wish you the best of luck with your stuff and hope you can handle it smoothly! |
I would be careful about adding another maintainer after the xz situation making sure your maintainers aren't bad actors should be part of the consideration of choosing a maintainer |
Hi! How are you doing? I'm interested in hearing about whether stuff goes well right now, that you're not having troubles with the things you need to do in your personal life. I appreciate the work developers put into these kinds of projects and want them to be doing well, as I know how hard such things can get, especially when there are other things that need attention. Hopefully, you will soon be able to also get this issue dealt with as well and with a fresh mind. 👍🏻 |
I'm aware — I spent much of the week after the incident documenting the bug in an article referenced by the NYT and NIST. That was a significant time sink. Thank you for your support @AlphaCraft9658 |
my concern is just having another xz situation because of a maintainer with malicious hidden intent its why you should be careful who you choose. I'm not saying you shouldn't you should just be sure that you aren't going to end up with someone who is going to put malware in the project. |
|
Hi! I just wanted to mention that it seems like the qt6-branch is basically ready to merge? Quite a few people have successfully built Lightly-qt6, and they don't seem to have any issues. |
|
Any updates? |
and others
I just finished updating to plasma 6 beta 1 and this style is not present anymore in the settings since it has to be ported to qt6.
The text was updated successfully, but these errors were encountered: