Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PHP 8.2 #142

Merged
merged 2 commits into from
Dec 10, 2022
Merged

Add support for PHP 8.2 #142

merged 2 commits into from
Dec 10, 2022

Conversation

internalsystemerror
Copy link
Contributor

@internalsystemerror internalsystemerror commented Dec 10, 2022 •
edited

This PR:

  • Adds support for PHP 8.2
  • Regenerates the lock file using PHP 7.4
  • Adds ext-simplexml as a requirement to composer to fix psalm errors around SimpleXMLElement

@internalsystemerror internalsystemerror mentioned this pull request Dec 10, 2022
Merged
@boesing
Copy link
Owner

boesing commented Dec 10, 2022

Do we need to drop PHP 7.4 here? I still have a personal need for 7.4 and thus, if not mandatory, I prefer to keep it if possible.

add support for PHP 8.2
b74b304 
Signed-off-by: Gary Lockett <gary@creativecow.uk>
@internalsystemerror
Copy link
Contributor Author

Updated, this removes the need to do a cs-fix which mainly adds uses of unions and constructor properties.

@internalsystemerror internalsystemerror changed the title Add support for PHP 8.2, drop support for PHP 7.4 Add support for PHP 8.2 Dec 10, 2022
@boesing
Copy link
Owner

boesing commented Dec 10, 2022

Awesome. Thanks!

update webmozart/assert to ^1.11.0
ab8b02b 
Signed-off-by: Gary Lockett <gary@creativecow.uk>
@internalsystemerror
Copy link
Contributor Author

Apparently webmozart/assert say they support PHP 8.2 when they didn't and support was actually added in 1.11.0, so I've bumped the minimum here.

@boesing boesing merged commit cb2d950 into boesing:1.4.x Dec 10, 2022
@boesing
Copy link
Owner

boesing commented Dec 10, 2022

Thanks, @internalsystemerror

@boesing boesing added the enhancement New feature or request label Dec 10, 2022
@boesing boesing added this to the 1.4.0 milestone Dec 10, 2022
@internalsystemerror internalsystemerror deleted the add-php82-support branch December 10, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@internalsystemerror @boesing