CommonJS support

[SaltyAom]

Elysia 0.5 add support for CommonJS by default, this should allow us to drop the additional step of using CLI to convert Elysia modules to CommonJS.

It would be nice if would you updated the package to support CommonJS as well.

[bogeychan]

Sounds good, I will give it a try.

But I think since you introduced code analysis, it won't work without a build step (before each run) because of bun transpile step, for example:

isFnUse

// Bun
let is = isFnUse(
  'set',
  `(context) => {
    if (handleOrigin(context.set, context.request), handleMethod(context.set), exposedHeaders.length)
      context.set.headers["Access-Control-Allow-Headers"] = typeof allowedHeaders === "string" ? allowedHeaders : allowedHeaders.join(", ");
    if (maxAge)
      context.set.headers["Access-Control-Max-Age"] = maxAge.toString();
    return new Response("", {
      status: 204
    });
  }`
);

console.log(is); // true

// Node
is = isFnUse(
  'set',
  `context => {
        handleOrigin(context.set, context.request);
        handleMethod(context.set);
        if (exposedHeaders.length) context.set.headers['Access-Control-Allow-Headers'] = typeof allowedHeaders === 'string' ? allowedHeaders : allowedHeaders.join(', ');
        if (maxAge) context.set.headers['Access-Control-Max-Age'] = maxAge.toString();
        return new Response('', {
          status: 204
        });
      }`
);

console.log(is); // false

bugs in Bun.build / bun build kinda blocks progress atm

[bogeychan]

I got it working without using Bun.build. I adjusted the following parts of isFnUse, in case you encounter the same problem in the future with bun.

elysia-polyfills/scripts/runtime.js

Lines 38 to 46 in 302ccea

	// >> INSERT
	fnLiteral = fnLiteral.trimStart();
	const argument = fnLiteral.startsWith('(')
	? // (context) => {}
	fnLiteral.slice(fnLiteral.indexOf('(') + 1, fnLiteral.indexOf(')'))
	: // context => {}
	fnLiteral.slice(0, fnLiteral.indexOf('=') - 1);
	// << INSERT

elysia-polyfills/scripts/runtime.js

Lines 51 to 57 in 302ccea

	// >> INSERT
	if (argument.includes(`{${keyword}`) || argument.includes(`,${keyword}`))
	return true;
	// << INSERT
	if (argument.includes(`{ ${keyword}`) || argument.includes(`, ${keyword}`))
	return true;

I'll look into CommonJS support tomorrow

[bogeychan]

CommonJS support should be added without build-step in @bogeychan/elysia-polyfills@0.5.1 and create-elysia@0.0.15:

yarn create elysia my-elysia-app --template node

If you want to support ESM hybrid with CJS in Elysia you can follow this blog post. I implemented the same approach.

Furthermore you have to use "moduleResolution": "nodenext", (i.e. specify all imports and exports with .js extension)