Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing headers and user-name header rotation #43

Merged
merged 8 commits into from
Mar 26, 2021
Merged

Add missing headers and user-name header rotation #43

merged 8 commits into from
Mar 26, 2021

Conversation

andig
Copy link
Collaborator

@andig andig commented Mar 11, 2021 •
edited
Loading

This does not solve the current login issues but exposes the login request flow using a logging http client.

Note: might also make sense to only update the transport: https://github.com/uhthomas/tesla/compare/f00d0e07a2b61907751647920f5b7c1f8197c07a..1caf33b692d9258ef27505b335ee3aa8869c1e8d#diff-c52daedaeda258db15ec11d57bbf299412a20328f6cd026980ef07f01960dd3aR25

@andig andig requested a review from uhthomas March 11, 2021 09:22
@andig andig mentioned this pull request Mar 11, 2021
Closed
@andig
Copy link
Collaborator Author

andig commented Mar 14, 2021

Added all changes from @uhthomas. Can get the login and api call. My only test car right now replies with 408 to the actual api call, but that might be ok? Also noted, that the new transport MUST NOT be used for the login itself.

ping @uhthomas

@andig andig changed the title Use provided context client for login Add missing headers and user-name header rotation Mar 14, 2021
@andig
Copy link
Collaborator Author

andig commented Mar 15, 2021

Fix #42

@andig andig requested a review from bogosj March 15, 2021 06:43
@uhthomas
Copy link
Collaborator

Sorry for being so inactive the past couple weeks - lots going on!

The changes LGTM, thanks. I made a couple more upstream; like using base32 and ensuring the clients / contexts are passed around correctly. Should we merge them here?

I can confirm that the client works, albeit with major rate limiting applied.

@andig
Copy link
Collaborator Author

andig commented Mar 19, 2021

The changes LGTM, thanks. I made a couple more upstream; like using base32 and ensuring the clients / contexts are passed around correctly. Should we merge them here?

Yes please! It's your PR anyway- please feel free to amend or open new one.

Btw., do you intend to keep maintaining your repo or wouldn't it be easier to do all evolution here?

@andig andig mentioned this pull request Mar 24, 2021
Merged
@andig
Copy link
Collaborator Author

andig commented Mar 24, 2021

ping @uhthomas seem we should get this closed before 1.0?

@andig andig added this to the 1.0 milestone Mar 25, 2021
@andig
Copy link
Collaborator Author

andig commented Mar 25, 2021

@uhthomas I've merged your base32 changes but didn't take over returning the context as I didn't understand why that's needed.

@andig
Copy link
Collaborator Author

andig commented Mar 26, 2021

@bogosj Rebased. Shall we get this in?

@bogosj bogosj merged commit e3261e5 into bogosj:main Mar 26, 2021
@andig andig deleted the feature/context-client branch March 26, 2021 13:40
michaelharo pushed a commit that referenced this pull request Apr 24, 2021
@andig @michaelharo
Add missing headers and user-name header rotation (#43)
eeb479d 
* Use provided context client for login

* Use tesla transport for authorization and client

* wip

* wip

* wip

* Merge remaining changes

* Fix linter errors

* Clarify code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogosj bogosj bogosj approved these changes

@uhthomas uhthomas Awaiting requested review from uhthomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andig @uhthomas @bogosj