Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for min and max month #113

Merged

Conversation

kevinvanmierlo
Copy link
Contributor

Added support for min and max month. This is the way the pager will now behave, so let me know if that's okay. It calculates how many pages there should be in LazyRow based on minMonth and maxMonth. Default it uses 10000 months in the past and 10000 in the future so it works the same as it already did. This fixes #112.

@kevinvanmierlo
Copy link
Contributor Author

@boguszpawlowski Do I need to do anything? It says Review required, but I'm assuming that is a review by you right?

Copy link
Owner

@boguszpawlowski boguszpawlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevinvanmierlo Thank you for the contribution, and apologies for the CR wait time. Overall, implementation LGTM, couple of minor comments:

@kevinvanmierlo
Copy link
Contributor Author

@boguszpawlowski No problem! Thanks for responding and adding the test results. I created a new commit which should fix the issues. I'll also reply on each test result to let you know what I've done.

@boguszpawlowski
Copy link
Owner

@kevinvanmierlo Looks good to go. Please adjust errors reported by Detekt (https://github.com/boguszpawlowski/ComposeCalendar/actions/runs/7540813612/job/20526357349?pr=113) and re-generate api scheme ./gradlew apiDump

@kevinvanmierlo
Copy link
Contributor Author

@boguszpawlowski I fixed the detekt issues. But it says it is still waiting for status to be reported. Is this something you need to run? I always thought it was automatic.

@boguszpawlowski boguszpawlowski merged commit a3ad7a4 into boguszpawlowski:main Jan 23, 2024
3 of 4 checks passed
@boguszpawlowski
Copy link
Owner

@kevinvanmierlo Thanks again for the contribution! Will release the new version of the library soon.

@kevinvanmierlo
Copy link
Contributor Author

No problem! It's a nice library :)
Do you have an estimate on when it'll be released? I'm using my own fork for now, but rather use this version.

@boguszpawlowski
Copy link
Owner

Probably sometime next week. I want to add the min/max for week calendar, bump libraries and test it first.

@kevinvanmierlo
Copy link
Contributor Author

Thank you! I get that you want to add that first. I'm looking forward to the release!

@boguszpawlowski
Copy link
Owner

@kevinvanmierlo Released 1.2.0. Should be available on Maven soon.

@kevinvanmierlo
Copy link
Contributor Author

@boguszpawlowski Awesome, thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar pager date range
2 participants