renamed the running_state mapping register names to fix name clash #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danielHin
commented
Jul 8, 2022
danielHin
commented
- import_from_grid has a name clash with the custom one calculated by SunGather
* import_from_grid has a name clash with the custom one calculated by SunGather
|
LGTM |
|
Merged |
michbeck100
added a commit
to michbeck100/SunGather
that referenced
this pull request
Jul 26, 2022
…anged by mistake in bohdan-s#59)
|
Unfortunately there was one register renamed that didn't belong to running_state. See #65 |
michbeck100
added a commit
to michbeck100/SunGather
that referenced
this pull request
Jul 26, 2022
…anged by mistake in bohdan-s#59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.