Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I recommend setting if(count($team = $this->getAliveTeams()) === 1 && count($this->players) <= $playerPerTeam){ #6

Closed
eforce67 opened this issue Mar 4, 2020 · 2 comments
Closed

I recommend setting if(count($team = $this->getAliveTeams()) === 1 && count($this->players) <= $playerPerTeam){ #6

eforce67 opened this issue Mar 4, 2020 · 2 comments

Comments

@eforce67
Copy link

eforce67 commented Mar 4, 2020

This could cause a problem if they aren't playing in solo mode of course but it will work differentially so use playerPerTeams since it counts the amount of players on a team and could potentially solve problems like chaos mode or duos. Also count the players if 0 > $playerPerTeam just canceling and switch to the reboot stage ;)
@jsnfjsfjbwiea jsnfjsfjbwiea mentioned this issue Mar 4, 2020
Closed
@boi1216 boi1216 closed this as completed Mar 4, 2020
@boi1216
Copy link
Owner

boi1216 commented Mar 4, 2020

It works fine right now

@boi1216 boi1216 reopened this Mar 4, 2020
@boi1216
Copy link
Owner

boi1216 commented Mar 4, 2020 •
edited

Fixed in 7dbb6e8

@boi1216 boi1216 closed this as completed Mar 4, 2020
@tnt10128 tnt10128 mentioned this issue Sep 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@boi1216 @eforce67